From 3bab16d733bbda92db11777b78ed53c2e7418091 Mon Sep 17 00:00:00 2001 From: sripaadpatel Date: Fri, 16 Jan 2026 01:40:56 +0530 Subject: [PATCH 1/2] Refactor: unify abs usage and expand type hints to float --- maths/abs.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/maths/abs.py b/maths/abs.py index b357e98d8680..08e239f61713 100644 --- a/maths/abs.py +++ b/maths/abs.py @@ -1,5 +1,5 @@ """Absolute Value.""" - +from __future__ import annotations def abs_val(num: float) -> float: """ @@ -15,7 +15,7 @@ def abs_val(num: float) -> float: return -num if num < 0 else num -def abs_min(x: list[int]) -> int: +def abs_min(x: list[int | float]) -> float: """ >>> abs_min([0,5,1,11]) 0 @@ -35,7 +35,7 @@ def abs_min(x: list[int]) -> int: return j -def abs_max(x: list[int]) -> int: +def abs_max(x: list[int | float]) -> float: # Changed type hint """ >>> abs_max([0,5,1,11]) 11 @@ -50,12 +50,12 @@ def abs_max(x: list[int]) -> int: raise ValueError("abs_max() arg is an empty sequence") j = x[0] for i in x: - if abs(i) > abs(j): + if abs_val(i) > abs_val(j): j = i return j -def abs_max_sort(x: list[int]) -> int: +def abs_max_sort(x: list[int | float]) -> float: """ >>> abs_max_sort([0,5,1,11]) 11 @@ -84,6 +84,10 @@ def test_abs_val(): assert abs_max_sort(a) == -11 assert abs_min(a) == -1 + b = [-3.5, 1.2, -10.1] + assert abs_max(b) == -10.1 + assert abs_min(b) == 1.2 + if __name__ == "__main__": import doctest From 7e5fe0304ceb924af06202b823cb8ae4ad5dd5b5 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 15 Jan 2026 20:13:50 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- maths/abs.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/maths/abs.py b/maths/abs.py index 08e239f61713..4b750d1f11c3 100644 --- a/maths/abs.py +++ b/maths/abs.py @@ -1,6 +1,8 @@ """Absolute Value.""" + from __future__ import annotations + def abs_val(num: float) -> float: """ Find the absolute value of a number. @@ -35,7 +37,7 @@ def abs_min(x: list[int | float]) -> float: return j -def abs_max(x: list[int | float]) -> float: # Changed type hint +def abs_max(x: list[int | float]) -> float: # Changed type hint """ >>> abs_max([0,5,1,11]) 11