chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877

daniel-sanche · 2025-12-06T00:29:30Z

it looks like this comment is saying an improvement is available to us now that we're dropping 3.7. Is that something we'd want to consider, or should we stick with the existing implementation?

I looked at this and it didn't seem like a cleaner alternative. I'm not sure what I had in mind when I first wrote this comment, but I think the current implementation is clean.

-Original file line number
+Diff line change
@@ Expand Up / @@ -35,15 +35,10 @@ jobs: @@
             nox -s prerelease_deps
       unit:
         name: unit${{ matrix.option }}-${{ matrix.python }}
-        # TODO(https://github.com/googleapis/gapic-generator-python/issues/2303): use `ubuntu-latest` once this bug is fixed.
-        # Use ubuntu-22.04 until Python 3.7 is removed from the test matrix
-        # https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
-        runs-on: ubuntu-22.04
+        runs-on: ubuntu-latest
         strategy:
           matrix:
             python:
-              - "3.7"
-              - "3.8"
               - "3.9"
               - "3.10"
               - "3.11"
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -33,8 +33,7 @@ export PYTHONUNBUFFERED=1 @@
     env | grep KOKORO
     # Install nox
-    # `virtualenv==20.26.6` is added for Python 3.7 compatibility
-    python3.9 -m pip install --upgrade --quiet nox virtualenv==20.26.6
+    python3.9 -m pip install --upgrade --quiet nox
     # Use secrets acessor service account to get secrets
     if [[ -f "${KOKORO_GFILE_DIR}/secrets_viewer_service_account.json" ]]; then
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,7 @@ In order to add a feature: @@
       documentation.
     - The feature must work fully on the following CPython versions:
-.7, 3.8, 3.9, 3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows.
+.9, 3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows.
     - The feature must not add unnecessary dependencies (where
       "unnecessary" is of course subjective, but new dependencies should
@@ Expand Down Expand Up / @@ -197,17 +197,13 @@ Supported Python Versions @@
     We support:
-    -  `Python 3.7`_
-    -  `Python 3.8`_
     -  `Python 3.9`_
     -  `Python 3.10`_
     -  `Python 3.11`_
     -  `Python 3.12`_
     -  `Python 3.13`_
     -  `Python 3.14`_
-    .. _Python 3.7: https://docs.python.org/3.7/
-    .. _Python 3.8: https://docs.python.org/3.8/
     .. _Python 3.9: https://docs.python.org/3.9/
     .. _Python 3.10: https://docs.python.org/3.10/
     .. _Python 3.11: https://docs.python.org/3.11/
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up @@
     Supported Python Versions
     -------------------------
-    Python >= 3.7
+    Python >= 3.9
     Unsupported Python Versions
     ---------------------------
-    Python == 2.7, Python == 3.5, Python == 3.6.
+    Python == 2.7, Python == 3.5, Python == 3.6, Python == 3.7, Python == 3.8.
     The last version of this library compatible with Python 2.7 and 3.5 is
     `google-api-core==1.31.1`.
     The last version of this library compatible with Python 3.6 is
     `google-api-core==2.8.2`.
+    The last version of this library compatible with Python 3.7 and 3.8 is
+    `google-api-core==2.29.0`.

-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,6 @@ @@
     """Code to check versions of dependencies used by Google Cloud Client Libraries."""
     import warnings
-    import sys
     from typing import Optional, Tuple
     from collections import namedtuple
@@ Expand All / @@ -25,12 +24,7 @@ @@
         _get_distribution_and_import_packages,
     )
-    if sys.version_info >= (3, 8):
-        from importlib import metadata
-    else:
-        # TODO(https://github.com/googleapis/python-api-core/issues/835): Remove
-        # this code path once we drop support for Python 3.7
-        import importlib_metadata as metadata
+    from importlib import metadata
     ParsedVersion = Tuple[int, ...]
@@ Expand Down Expand Up / @@ -85,8 +79,7 @@ def get_dependency_version( @@
         """Get the parsed version of an installed package dependency.
         This function checks for an installed package and returns its version
-        as a comparable tuple of integers object for safe comparison. It handles
-        both modern (Python 3.8+) and legacy (Python 3.7) environments.
+        as a comparable tuple of integers object for safe comparison.
         Args:
             dependency_name: The distribution name of the package (e.g., 'requests').
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniel-sanche Dec 6, 2025

Uh oh!

vchudnov-g Dec 8, 2025

Uh oh!

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ Expand Up / @@ -31,9 +31,6 @@ @@
     class _MethodDefault(enum.Enum):
         # Uses enum so that pytype/mypy knows that this is the only possible value.
         # https://stackoverflow.com/a/60605919/101923
-        #
-        # Literal[_DEFAULT_VALUE] is an alternative, but only added in Python 3.8.
-        # https://docs.python.org/3/library/typing.html#typing.Literal
         _DEFAULT_VALUE = object()
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -27,25 +27,7 @@ @@
     from google.api_core import exceptions, general_helpers
-    PROTOBUF_VERSION = google.protobuf.__version__
-    # The grpcio-gcp package only has support for protobuf < 4
-    if PROTOBUF_VERSION[0:2] == "3.":  # pragma: NO COVER
-        try:
-            import grpc_gcp
-            warnings.warn(
-                """Support for grpcio-gcp is deprecated. This feature will be
-                removed from `google-api-core` after January 1, 2024. If you need to
-                continue to use this feature, please pin to a specific version of
-                `google-api-core`.""",
-                DeprecationWarning,
-            )
-            HAS_GRPC_GCP = True
-        except ImportError:
-            HAS_GRPC_GCP = False
-    else:
-        HAS_GRPC_GCP = False
+    HAS_GRPC_GCP = False
     # The list of gRPC Callable interfaces that return iterators.
@@ Expand Down Expand Up / @@ -366,8 +348,7 @@ def create_channel( @@
                   result in `ValueError` as this combination  is not yet supported.
             kwargs: Additional key-word args passed to
-                :func:`grpc_gcp.secure_channel` or :func:`grpc.secure_channel`.
-                Note: `grpc_gcp` is only supported in environments with protobuf < 4.0.0.
+                :func:`grpc.secure_channel`.
         Returns:
             grpc.Channel: The created channel.
@@ Expand All / @@ -393,20 +374,6 @@ def create_channel( @@
             default_host=default_host,
         )
-        # Note that grpcio-gcp is deprecated
-        if HAS_GRPC_GCP:  # pragma: NO COVER
-            if compression is not None and compression != grpc.Compression.NoCompression:
-                warnings.warn(
-                    "The `compression` argument is ignored for grpc_gcp.secure_channel creation.",
-                    DeprecationWarning,
-                )
-            if attempt_direct_path:
-                warnings.warn(
-                    """The `attempt_direct_path` argument is ignored for grpc_gcp.secure_channel creation.""",
-                    DeprecationWarning,
-                )
-            return grpc_gcp.secure_channel(target, composite_credentials, **kwargs)
         if attempt_direct_path:
             target = _modify_target_for_direct_path(target)
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -33,7 +33,7 @@ @@
         from google.api_core.operations_v1.operations_rest_client_async import AsyncOperationsRestClient
         __all__ += ["AsyncOperationsRestClient", "AsyncOperationsRestTransport"]
-    except ImportError:
+    except ImportError:  # pragma: NO COVER
         # This import requires the `async_rest` extra.
         # Don't raise an exception if `AsyncOperationsRestTransport` cannot be imported
         # as other transports are still available.
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -32,7 +32,7 @@ @@
         )
         HAS_ASYNC_REST_DEPENDENCIES = True
-    except ImportError as e:
+    except ImportError as e:  # pragma: NO COVER
         HAS_ASYNC_REST_DEPENDENCIES = False
         ASYNC_REST_EXCEPTION = e
@@ Expand All / @@ -51,7 +51,7 @@ class AbstractOperationsBaseClientMeta(type): @@
         _transport_registry = OrderedDict()  # type: Dict[str, Type[OperationsTransport]]
         _transport_registry["rest"] = OperationsRestTransport
-        if HAS_ASYNC_REST_DEPENDENCIES:
+        if HAS_ASYNC_REST_DEPENDENCIES:  # pragma: NO COVER
             _transport_registry["rest_asyncio"] = AsyncOperationsRestTransport
         def get_transport_class(
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -12,4 +12,4 @@ @@
     # See the License for the specific language governing permissions and
     # limitations under the License.
-    __version__ = "2.29.0"
+    __version__ = "2.29.1"

chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877

Are you sure you want to change the base?

chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daniel-sanche Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!