Skip to content

Rename submission modes: benchmark→private, leaderboard→public #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msaroufim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename submission modes: benchmark→private, leaderboard→public #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/cmd/submit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@ impl App {
"test".to_string(),
),
SubmissionModeItem::new(
"Benchmark".to_string(),
"Benchmark the solution, this also runs the tests and afterwards runs the benchmark, returning detailed timing results".to_string(),
"benchmark".to_string(),
"Private".to_string(),
"Run benchmarks privately. Returns detailed timing results but doesn't affect leaderboard ranking.".to_string(),
"private".to_string(),
),
SubmissionModeItem::new(
"Leaderboard".to_string(),
"Submit to the leaderboard, this first runs public tests and then private tests. If both pass, the submission is evaluated and submit to the leaderboard.".to_string(),
"leaderboard".to_string(),
"Public".to_string(),
"Submit to the public leaderboard. Runs tests, then benchmarks, and if all pass, evaluates and ranks your submission.".to_string(),
"public".to_string(),
),
SubmissionModeItem::new(
"Profile".to_string(),
Expand Down Expand Up @@ -731,7 +731,7 @@ pub async fn run_submit_plain(
})?;

let final_mode = mode.ok_or_else(|| {
anyhow!("Submission mode not specified. Use --mode flag (test, benchmark, leaderboard, profile)")
anyhow!("Submission mode not specified. Use --mode flag (test, private, public, profile)")
})?;

// Read file content
Expand Down