Fix NPM release workflow to use micromamba environment #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jlpm command wasn't available because commands weren't running in the micromamba environment where JupyterLab is installed. Use 'micromamba run -n ipympl-release' to execute commands in the correct environment. Fixes matplotlib#616 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Collaborator
Author
|
not really sure how to test without releasing |
Contributor
|
|
Member
|
I'm not sure that would work. Publishing by NPM token is disallowed now, we would need to setup trusted publishers on the npmjs package. I'm also fine if you release manually. |
Collaborator
Author
|
I will see if I can set up trusted publishers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'micromamba run -n ipympl-release' to execute commands in the correct environment.
Fixes #616 (I hope)