Skip to content

Add feature switches for Type marshalling and IDIC support #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sergio0694 wants to merge 10 commits into
base: user/kythant/TypeHandling
Choose a base branch
from
Draft

Add feature switches for Type marshalling and IDIC support #2223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9a0c335
Replace ConditionalWeakTable with ConcurrentDictionary
Sergio0694 Feb 3, 2026
9e5cfe3
Refactor Type marshalling and add caches
Sergio0694 Feb 3, 2026
00bab06
Add EnableXamlTypeMarshalling feature switch
Sergio0694 Feb 3, 2026
98ca94e
Guard Type marshalling behind feature switch
Sergio0694 Feb 3, 2026
2a5c138
Remove default CsWinRT feature switches
Sergio0694 Feb 3, 2026
686b9a9
Add XAML type marshalling runtime option
Sergio0694 Feb 3, 2026
447dcc3
Add feature switch for IDynamicInterfaceCastable
Sergio0694 Feb 4, 2026
765d515
Extract IDynamicInterfaceCastable exception stub
Sergio0694 Feb 4, 2026
d1fe0c7
Fix typos
Sergio0694 Feb 4, 2026
e4577be
Guard Type marshalling with feature switch
Sergio0694 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 9 additions & 36 deletions nuget/Microsoft.Windows.CsWinRT.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,14 +568,10 @@ $(CsWinRTInternalProjection)

<!-- Default values for all custom CsWinRT runtime feature switches -->
<PropertyGroup>
<CsWinRTEnableDynamicObjectsSupport Condition="'$(CsWinRTEnableDynamicObjectsSupport)' == ''">true</CsWinRTEnableDynamicObjectsSupport>
<CsWinRTUseExceptionResourceKeys Condition="'$(CsWinRTUseExceptionResourceKeys)' == ''">false</CsWinRTUseExceptionResourceKeys>
<CsWinRTEnableDefaultCustomTypeMappings Condition="'$(CsWinRTEnableDefaultCustomTypeMappings)' == ''">true</CsWinRTEnableDefaultCustomTypeMappings>
<CsWinRTEnableICustomPropertyProviderSupport Condition="'$(CsWinRTEnableICustomPropertyProviderSupport)' == ''">true</CsWinRTEnableICustomPropertyProviderSupport>
<CsWinRTEnableIReferenceSupport Condition="'$(CsWinRTEnableIReferenceSupport)' == ''">true</CsWinRTEnableIReferenceSupport>
<CsWinRTEnableIDynamicInterfaceCastableSupport Condition="'$(CsWinRTEnableIDynamicInterfaceCastableSupport)' == ''">true</CsWinRTEnableIDynamicInterfaceCastableSupport>
<CsWinRTEnableManifestFreeActivation Condition="'$(CsWinRTEnableManifestFreeActivation)' == ''">true</CsWinRTEnableManifestFreeActivation>
<CsWinRTManifestFreeActivationReportOriginalException Condition="'$(CsWinRTManifestFreeActivationReportOriginalException)' == ''">false</CsWinRTManifestFreeActivationReportOriginalException>
<CsWinRTEnableXamlTypeMarshalling Condition="'$(CsWinRTEnableXamlTypeMarshalling)' == ''">true</CsWinRTEnableXamlTypeMarshalling>
<CsWinRTLoadComponentsInDefaultALC Condition="'$(CsWinRTLoadComponentsInDefaultALC)' == ''">false</CsWinRTLoadComponentsInDefaultALC>

<!--
Expand All @@ -584,39 +580,11 @@ $(CsWinRTInternalProjection)
-->
</PropertyGroup>

<!--
Configuration for the feature switches (to support IL trimming).
See the 'ILLink.Substitutions.xml' file for more details on that.
-->
<!-- Configuration for the feature switches (to support IL trimming) -->
<ItemGroup>

<!-- CSWINRT_ENABLE_DYNAMIC_OBJECTS_SUPPORT switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_ENABLE_DYNAMIC_OBJECTS_SUPPORT"
Value="$(CsWinRTEnableDynamicObjectsSupport)"
Trim="true" />

<!-- CSWINRT_USE_EXCEPTION_RESOURCE_KEYS switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_USE_EXCEPTION_RESOURCE_KEYS"
Value="$(CsWinRTUseExceptionResourceKeys)"
Trim="true" />

<!-- CSWINRT_ENABLE_DEFAULT_CUSTOM_TYPE_MAPPINGS switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_ENABLE_DEFAULT_CUSTOM_TYPE_MAPPINGS"
Value="$(CsWinRTEnableDefaultCustomTypeMappings)"
Trim="true" />

<!-- CSWINRT_ENABLE_ICUSTOMPROPERTYPROVIDER_SUPPORT switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_ENABLE_ICUSTOMPROPERTYPROVIDER_SUPPORT"
Value="$(CsWinRTEnableICustomPropertyProviderSupport)"
Trim="true" />

<!-- CSWINRT_ENABLE_IREFERENCE_SUPPORT switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_ENABLE_IREFERENCE_SUPPORT"
Value="$(CsWinRTEnableIReferenceSupport)"
Trim="true" />

<!-- CSWINRT_ENABLE_IDYNAMICINTERFACECASTABLE switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_ENABLE_IDYNAMICINTERFACECASTABLE"
<!-- CSWINRT_ENABLE_IDYNAMICINTERFACECASTABLE_SUPPORT switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_ENABLE_IDYNAMICINTERFACECASTABLE_SUPPORT"
Value="$(CsWinRTEnableIDynamicInterfaceCastableSupport)"
Trim="true" />

Expand All @@ -629,6 +597,11 @@ $(CsWinRTInternalProjection)
<RuntimeHostConfigurationOption Include="CSWINRT_MANIFEST_FREE_ACTIVATION_REPORT_ORIGINAL_EXCEPTION"
Value="$(CsWinRTManifestFreeActivationReportOriginalException)"
Trim="true" />

<!-- CSWINRT_ENABLE_XAML_TYPE_MARSHALLING switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_ENABLE_XAML_TYPE_MARSHALLING"
Value="$(CsWinRTEnableXamlTypeMarshalling)"
Trim="true" />

<!-- CSWINRT_LOAD_COMPONENTS_IN_DEFAULT_ALC switch -->
<RuntimeHostConfigurationOption Include="CSWINRT_LOAD_COMPONENTS_IN_DEFAULT_ALC"
Expand Down
Loading
Loading