Pluggable transport #1936
Closed
Pluggable transport #1936
+4,025
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Proto definition (proto/mcp/v1/mcp.proto) with native streaming RPCs - Python GrpcClientTransport implementing ClientTransportSession - Streaming support for progress, parallel tools, chunked resources, watches - Bidirectional Session RPC for complex agent interactions
- Implement Session stream for multiplexed requests/responses - Add chunked resource reading via ReadResourceChunked RPC - Add background resource watchers for push notifications - Add proper gRPC error mapping to Python exceptions - Generate proto stubs to src/mcp/v1/ - Add grpc optional dependency to pyproject.toml - Add advanced streaming patterns documentation - Update docs navigation with gRPC transport links
- Replace paginated List RPCs with streaming equivalents - Simplify request/response structures by removing cursor fields - Align with gRPC streaming best practices on branch `streaming-updates`
- Add `Open Questions` section in proto/README.md for stream vs pagination discussion - Detail current implementation limits and considerations for true streaming - Propose potential enhancements like client-requested limits and async generators in Server implementation - Refine gRPC transport documentation on branch `streaming-updates`
- Implement `GrpcServerSession` for handling gRPC request contexts - Add `McpGrpcServicer` for mapping MCP server methods to gRPC services - Support unary and streaming RPCs for tools, resources, and prompts - Provide bidirectional communication with `Session` stream - Include helper methods for protobuf type conversions - Add `start_grpc_server` to initialize gRPC server with optional TLS support - Enhance logging and error handling for incomplete gRPC features
…s, prompts, and templates on branch `streaming-updates` - Replace cursor-based pagination with streaming iterations - Adjust return types to collect results from async streams - Add warnings for unsupported cursor usage - Enhance readability and maintain consistency across list methods
- Implement tests for gRPC server and client interactions - Verify tool calls, resource management, progress tracking, and prompts consistency - Ensure handling of errors and maintaining session health
…ests for gRPC module on branch `streaming-updates`
…tions in `proto/README.md` on branch `streaming-updates` - Introduce a memory-efficient streaming alternative to existing `ClientTransportSession` methods - Ensure backward compatibility with existing implementations - Pose open design questions about streaming abstraction
Contributor
|
Hey! I appreciate the work you've put into this but unfortunately I'm going to close this PR for a few reasons:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation and example code to consistently use the new
ServerTransportSessionandClientTransportSessiontypes instead of the previousServerSessionandClientSessiontypes. It also introduces a new experimental documentation file explaining advanced gRPC streaming and multiplexing patterns, and updates the main documentation index to reference these new resources. These changes improve clarity around transport session usage and highlight advanced features available with gRPC.Session Type Migration (Most Important):
ServerTransportSessionin place ofServerSessionfor type annotations in tool functions and context usage. (README.md,examples/snippets/servers/elicitation.py,examples/snippets/servers/lifespan_example.py,examples/snippets/servers/notifications.py) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]ClientTransportSessionin place ofClientSessionfor type annotations, function parameters, and session instantiation. (README.md,examples/clients/simple-auth-client/mcp_simple_auth_client/main.py,examples/clients/simple-chatbot/mcp_simple_chatbot/main.py,examples/snippets/clients/display_utilities.py,examples/snippets/clients/stdio_client.py) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Documentation and Reference Updates:
docs/experimental/grpc-streaming.mdthat explains advanced gRPC streaming, multiplexing, binary transfer, push notifications, and best practices for high-performance MCP usage.docs/index.md) to reference the new gRPC transport and streaming documentation, and reordered the navigation for clarity.These changes ensure that all examples and documentation are aligned with the latest transport session abstractions and highlight advanced usage patterns for developers adopting gRPC in MCP.