Skip to content

probe_oen.pio doesn't set SWCLK as a sideset pin #196

@lurch

Description

@lurch

Whilst looking at #194 I noticed that probe.pio says:

    // Set SWCLK as a sideset pin
    sm_config_set_sideset_pins(sm_config, PROBE_PIN_SWCLK);

(i.e. the comment matches the code), whereas probe_oen.pio says:

    // Set SWDIOEN and SWCLK as sideset pins
    sm_config_set_sideset_pins(sm_config, PROBE_PIN_SWDIOEN);

i.e. despite what the comment says, it doesn't actually set SWCLK as a sideset pin.

Not being familiar with how this code works, I don't know if probe_oen.pio is accidentally missing a sm_config_set_sideset_pins(sm_config, PROBE_PIN_SWCLK); line, or whether the comment simply needs updating to // Set SWDIOEN as a sideset pin ? 🤷‍♂️

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions