Skip to content

Conversation

@mhemmer-cern
Copy link
Collaborator

  • Add AreSelectedRunning function to V0PhotonCuts class, which allows the usage of EMButFlags once at the beginning of a process function instead of checking each V0 photon inside the pair loops.
  • Add basic QA for V0Photons in the V0PhotonCuts class. To use it one must set the flag by using setDoQA(true) AND providing a pointer to the histogram registry of the main task. To initilize the histograms one needs to call fV0PhotonCut.addQAHistograms(&registry) in the init function of the task. For proper usage one needs to use AreSelectedRunning. It is possible to do it with the single V0 check function IsSelected(), however, not all histograms will be properly filled in that case.
  • Fix basic QA inside EMCPhotonCuts

- Add `AreSelectedRunning` function to V0PhotonCuts class, which allows the usage of `EMButFlags` once at the beginning of a process function instead of checking each V0 photon inside the pair loops.
- Add basic QA for V0Photons in the V0PhotonCuts class. To use it one must set the flag by using `setDoQA(true)` AND providing a pointer to the histogram registry of the main task. To initilize the histograms one needs to call `fV0PhotonCut.addQAHistograms(&registry)` in the init function of the task. For proper usage one needs to use `AreSelectedRunning`. It is possible to do it with the single V0 check function IsSelected(), however, not all histograms will be properly filled in that case.
- Fix basic QA inside EMCPhotonCuts
@github-actions github-actions bot added the pwgem label Feb 6, 2026
@mhemmer-cern mhemmer-cern added the photon Photon and neutral meson PAG label label Feb 6, 2026
@mhemmer-cern mhemmer-cern enabled auto-merge (squash) February 6, 2026 14:14
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@ktf
Copy link
Member

ktf commented Feb 8, 2026

The error on macOS seems to be genuine. Can you have a look?

@mhemmer-cern
Copy link
Collaborator Author

The error on macOS seems to be genuine. Can you have a look?

I just checked and it is not genuine, the variable is used:

vec_min_chi2MatchMCHMFT.emplace_back(tupleIds_at_min_chi2mftmch);

It was modified last by this PR #14760

@ktf
Copy link
Member

ktf commented Feb 9, 2026

@mhemmer-cern actually it was and I fixed it in 9a2575e. I think the one you refer to is on a different line. Anyway, this is unrelated to this PR. Merging.

@ktf ktf disabled auto-merge February 9, 2026 09:09
@ktf ktf merged commit 636b31f into AliceO2Group:master Feb 9, 2026
11 of 13 checks passed
@mhemmer-cern
Copy link
Collaborator Author

@mhemmer-cern actually it was and I fixed it in 9a2575e. I think the one you refer to is on a different line. Anyway, this is unrelated to this PR. Merging.

Ah okay, then there must have been multiple declarations of that variable at some point before or something. Thanks for checking and merging!

@mhemmer-cern mhemmer-cern deleted the PWGEM-36 branch February 9, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

3 participants