Added functionality similar to parquet-tools to print info of parquet…#65
Open
Added functionality similar to parquet-tools to print info of parquet…#65
Conversation
…enient-introspection-of-parquet-files
Collaborator
Author
|
Testing: |
Collaborator
Author
|
remote file |
Collaborator
Author
|
xieandrew
reviewed
Jan 22, 2026
Collaborator
xieandrew
left a comment
There was a problem hiding this comment.
Tested the commands and everything seems to work. Just a few comments.
| Option... options) | ||
| throws IOException { | ||
|
|
||
| Lazy<software.amazon.awssdk.services.s3.S3Client> s3ClientLazy = |
| } | ||
|
|
||
| public static void run(InputFile inputFile, boolean json, Option... options) throws IOException { | ||
|
|
Collaborator
There was a problem hiding this comment.
Empty line here could be removed
| System.setOut(new PrintStream(outContent)); | ||
|
|
||
| try { | ||
| InMemoryCatalog catalog = new InMemoryCatalog(); |
Collaborator
There was a problem hiding this comment.
InMemoryCatalog implements Closeable, should this be in a try with resources statement combined with the previous line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… files.