feat: Bounty: Deeplinks support + Raycast Extension #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
| ] | ||
| } | ||
| } | ||
| "$schema": "../node_modules/@tauri-apps/cli/schema.json", |
There was a problem hiding this comment.
This rewrites tauri.conf.json from the repo's current Tauri v2 format into a v1-style config (tauri.allowlist, package, etc). If desktop is still on Tauri v2, this is likely to fail to parse/build. Might be safer to keep the existing v2 structure and only add the new deeplink schemes under plugins.deep-link.desktop.schemes.
| "startDragging": true | ||
| }, | ||
| "fs": { | ||
| "all": true, |
There was a problem hiding this comment.
allowlist.fs.all: true (plus path/os/dialog/notification/globalShortcut all enabled) is extremely permissive. If this is intentional, can we scope it down to the minimal set of APIs needed for deeplinks?
| } | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: add a trailing newline so this file doesn't show \ No newline at end of file.
Suggested change
| } | |
| } |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+14
to
+49
| "allowlist": { | ||
| "all": false, | ||
| "shell": { | ||
| "all": false, | ||
| "open": true | ||
| }, | ||
| "window": { | ||
| "all": false, | ||
| "close": true, | ||
| "hide": true, | ||
| "show": true, | ||
| "maximize": true, | ||
| "minimize": true, | ||
| "unmaximize": true, | ||
| "unminimize": true, | ||
| "startDragging": true | ||
| }, | ||
| "fs": { | ||
| "all": true, | ||
| "scope": ["$HOME/**", "$RESOURCE/**"] | ||
| }, | ||
| "path": { | ||
| "all": true | ||
| }, | ||
| "os": { | ||
| "all": true | ||
| }, | ||
| "dialog": { | ||
| "all": true | ||
| }, | ||
| "notification": { | ||
| "all": true | ||
| }, | ||
| "globalShortcut": { | ||
| "all": true | ||
| } |
Contributor
There was a problem hiding this comment.
The allowlist configuration is Tauri v1 syntax and was completely removed in Tauri v2. In v2, permissions are managed through the new capability system with manifest files. This entire section will cause errors.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 14:49
Comment:
The `allowlist` configuration is Tauri v1 syntax and was completely removed in Tauri v2. In v2, permissions are managed through the new capability system with manifest files. This entire section will cause errors.
How can I resolve this? If you propose a fix, please make it concise.| "icons/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "identifier": "com.cap.desktop", |
Contributor
There was a problem hiding this comment.
Bundle identifier changed from so.cap.desktop.dev to com.cap.desktop. This would require re-signing and could break existing installations.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 66:66
Comment:
Bundle identifier changed from `so.cap.desktop.dev` to `com.cap.desktop`. This would require re-signing and could break existing installations.
How can I resolve this? If you propose a fix, please make it concise.| "macOS": { | ||
| "entitlements": null, | ||
| "exceptionDomain": "", | ||
| "frameworks": [], |
Contributor
There was a problem hiding this comment.
The frameworks array was changed from ["../../../target/native-deps/Spacedrive.framework"] to empty []. The Spacedrive framework is required for the desktop app functionality.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 71:71
Comment:
The `frameworks` array was changed from `["../../../target/native-deps/Spacedrive.framework"]` to empty `[]`. The Spacedrive framework is required for the desktop app functionality.
How can I resolve this? If you propose a fix, please make it concise.| "providerShortName": null, | ||
| "signingIdentity": null | ||
| }, | ||
| "resources": [], |
Contributor
There was a problem hiding this comment.
The resources were changed from a detailed mapping of background assets and Rive files to an empty array []. The app requires these bundled resources:
assets/backgrounds/macOS/*assets/backgrounds/blue/*,dark/*,orange/*,purple/*../src/assets/rive/*.riv
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 75:75
Comment:
The `resources` were changed from a detailed mapping of background assets and Rive files to an empty array `[]`. The app requires these bundled resources:
- `assets/backgrounds/macOS/*`
- `assets/backgrounds/blue/*`, `dark/*`, `orange/*`, `purple/*`
- `../src/assets/rive/*.riv`
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+84
to
+86
| "security": { | ||
| "csp": null | ||
| }, |
Contributor
There was a problem hiding this comment.
Security CSP was removed (changed from a detailed CSP string to null). The original CSP allowed specific sources:
default-src 'self' ws: ipc: http://ipc.localhost; img-src 'self' asset: http://asset.localhost blob: data:; media-src 'self' asset: http://asset.localhost; script-src 'self' 'unsafe-eval' 'wasm-unsafe-eval'; style-src 'self' 'unsafe-inline'
This was required for the asset protocol to work properly.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 84:86
Comment:
Security CSP was removed (changed from a detailed CSP string to `null`). The original CSP allowed specific sources:
```
default-src 'self' ws: ipc: http://ipc.localhost; img-src 'self' asset: http://asset.localhost blob: data:; media-src 'self' asset: http://asset.localhost; script-src 'self' 'unsafe-eval' 'wasm-unsafe-eval'; style-src 'self' 'unsafe-inline'
```
This was required for the asset protocol to work properly.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+4
to
+7
| "beforeBuildCommand": "pnpm build", | ||
| "beforeDevCommand": "pnpm dev:ui", | ||
| "devPath": "http://localhost:3001", | ||
| "distDir": "../dist" |
Contributor
There was a problem hiding this comment.
Build commands are incorrect. Changed:
beforeDevCommand:pnpm localdevtopnpm dev:uidevUrl: port 3002 to port 3001beforeBuildCommand:pnpm turbo build --filter @cap/desktoptopnpm buildfrontendDist:../.output/publicto../dist
Per package.json, the desktop app uses vinxi with localdev script on port 3002, and builds to ../.output/public.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 4:7
Comment:
Build commands are incorrect. Changed:
- `beforeDevCommand`: `pnpm localdev` to `pnpm dev:ui`
- `devUrl`: port 3002 to port 3001
- `beforeBuildCommand`: `pnpm turbo build --filter @cap/desktop` to `pnpm build`
- `frontendDist`: `../.output/public` to `../dist`
Per `package.json`, the desktop app uses `vinxi` with `localdev` script on port 3002, and builds to `../.output/public`.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+114
| { | ||
| "$schema": "https://schema.tauri.app/config/2", | ||
| "productName": "Cap - Development", | ||
| "identifier": "so.cap.desktop.dev", | ||
| "mainBinaryName": "Cap - Development", | ||
| "build": { | ||
| "beforeDevCommand": "pnpm localdev", | ||
| "devUrl": "http://localhost:3002", | ||
| "beforeBuildCommand": "pnpm turbo build --filter @cap/desktop", | ||
| "frontendDist": "../.output/public" | ||
| }, | ||
| "app": { | ||
| "macOSPrivateApi": true, | ||
| "security": { | ||
| "csp": "default-src 'self' ws: ipc: http://ipc.localhost; img-src 'self' asset: http://asset.localhost blob: data:; media-src 'self' asset: http://asset.localhost; script-src 'self' 'unsafe-eval' 'wasm-unsafe-eval'; style-src 'self' 'unsafe-inline'", | ||
| "assetProtocol": { | ||
| "enable": true, | ||
| "scope": [ | ||
| "$APPDATA/**", | ||
| "**/*.jpg", | ||
| "**/*.webp", | ||
| "$RESOURCE/**", | ||
| "**/*.riv", | ||
| "$HOME/**" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "plugins": { | ||
| "updater": { "active": false, "pubkey": "" }, | ||
| "deep-link": { | ||
| "desktop": { | ||
| "schemes": ["cap-desktop"] | ||
| } | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "createUpdaterArtifacts": true, | ||
| "targets": "all", | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/macos/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "resources": { | ||
| "assets/backgrounds/macOS/*": "assets/backgrounds/macOS/", | ||
| "assets/backgrounds/blue/*": "assets/backgrounds/blue/", | ||
| "assets/backgrounds/dark/*": "assets/backgrounds/dark/", | ||
| "assets/backgrounds/orange/*": "assets/backgrounds/orange/", | ||
| "assets/backgrounds/purple/*": "assets/backgrounds/purple/", | ||
| "../src/assets/rive/*.riv": "assets/rive/" | ||
| }, | ||
| "macOS": { | ||
| "dmg": { | ||
| "background": "assets/dmg-background.png", | ||
| "appPosition": { | ||
| "x": 180, | ||
| "y": 140 | ||
| }, | ||
| "applicationFolderPosition": { | ||
| "x": 480, | ||
| "y": 140 | ||
| } | ||
| }, | ||
| "frameworks": ["../../../target/native-deps/Spacedrive.framework"] | ||
| }, | ||
| "windows": { | ||
| "nsis": { | ||
| "headerImage": "assets/nsis-header.bmp", | ||
| "sidebarImage": "assets/nsis-sidebar.bmp", | ||
| "installerIcon": "icons/icon.ico" | ||
| }, | ||
| "wix": { | ||
| "upgradeCode": "79f4309d-ca23-54df-b6f9-826a1d783676", | ||
| "bannerPath": "assets/wix-banner.bmp", | ||
| "dialogImagePath": "assets/wix-dialog.bmp" | ||
| } | ||
| }, | ||
| "fileAssociations": [ | ||
| { | ||
| "ext": ["cap"], | ||
| "name": "Cap Project", | ||
| "mimeType": "application/x-cap-project", | ||
| "role": "Editor" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| "$schema": "../node_modules/@tauri-apps/cli/schema.json", | ||
| "build": { | ||
| "beforeBuildCommand": "pnpm build", | ||
| "beforeDevCommand": "pnpm dev:ui", | ||
| "devPath": "http://localhost:3001", | ||
| "distDir": "../dist" | ||
| }, | ||
| "package": { | ||
| "productName": "Cap", | ||
| "version": "../package.json" | ||
| }, | ||
| "tauri": { | ||
| "allowlist": { | ||
| "all": false, | ||
| "shell": { | ||
| "all": false, | ||
| "open": true | ||
| }, | ||
| "window": { | ||
| "all": false, | ||
| "close": true, | ||
| "hide": true, | ||
| "show": true, | ||
| "maximize": true, | ||
| "minimize": true, | ||
| "unmaximize": true, | ||
| "unminimize": true, | ||
| "startDragging": true | ||
| }, | ||
| "fs": { | ||
| "all": true, | ||
| "scope": ["$HOME/**", "$RESOURCE/**"] | ||
| }, | ||
| "path": { | ||
| "all": true | ||
| }, | ||
| "os": { | ||
| "all": true | ||
| }, | ||
| "dialog": { | ||
| "all": true | ||
| }, | ||
| "notification": { | ||
| "all": true | ||
| }, | ||
| "globalShortcut": { | ||
| "all": true | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "category": "DeveloperTool", | ||
| "copyright": "", | ||
| "deb": { | ||
| "depends": [] | ||
| }, | ||
| "externalBin": [], | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "identifier": "com.cap.desktop", | ||
| "longDescription": "", | ||
| "macOS": { | ||
| "entitlements": null, | ||
| "exceptionDomain": "", | ||
| "frameworks": [], | ||
| "providerShortName": null, | ||
| "signingIdentity": null | ||
| }, | ||
| "resources": [], | ||
| "shortDescription": "", | ||
| "targets": "all", | ||
| "windows": { | ||
| "certificateThumbprint": null, | ||
| "digestAlgorithm": "sha256", | ||
| "timestampUrl": "" | ||
| } | ||
| }, | ||
| "security": { | ||
| "csp": null | ||
| }, | ||
| "updater": { | ||
| "active": false | ||
| }, | ||
| "windows": [ | ||
| { | ||
| "fullscreen": false, | ||
| "height": 600, | ||
| "resizable": true, | ||
| "title": "Cap", | ||
| "width": 800 | ||
| } | ||
| ], | ||
| "systemTray": { | ||
| "iconPath": "icons/icon.png", | ||
| "iconAsTemplate": true | ||
| }, | ||
| "protocols": [ | ||
| { | ||
| "name": "cap-auth", | ||
| "schemes": ["cap-auth"] | ||
| }, | ||
| { | ||
| "name": "cap-deeplink", | ||
| "schemes": ["cap"] | ||
| } | ||
| ] | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Missing app.macOSPrivateApi: true configuration. Per apps/desktop/src-tauri/Cargo.toml:23, the app depends on macos-private-api feature and uses tauri-nspanel (line 136) which requires this flag in the config.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 1:114
Comment:
Missing `app.macOSPrivateApi: true` configuration. Per `apps/desktop/src-tauri/Cargo.toml:23`, the app depends on `macos-private-api` feature and uses `tauri-nspanel` (line 136) which requires this flag in the config.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+114
| { | ||
| "$schema": "https://schema.tauri.app/config/2", | ||
| "productName": "Cap - Development", | ||
| "identifier": "so.cap.desktop.dev", | ||
| "mainBinaryName": "Cap - Development", | ||
| "build": { | ||
| "beforeDevCommand": "pnpm localdev", | ||
| "devUrl": "http://localhost:3002", | ||
| "beforeBuildCommand": "pnpm turbo build --filter @cap/desktop", | ||
| "frontendDist": "../.output/public" | ||
| }, | ||
| "app": { | ||
| "macOSPrivateApi": true, | ||
| "security": { | ||
| "csp": "default-src 'self' ws: ipc: http://ipc.localhost; img-src 'self' asset: http://asset.localhost blob: data:; media-src 'self' asset: http://asset.localhost; script-src 'self' 'unsafe-eval' 'wasm-unsafe-eval'; style-src 'self' 'unsafe-inline'", | ||
| "assetProtocol": { | ||
| "enable": true, | ||
| "scope": [ | ||
| "$APPDATA/**", | ||
| "**/*.jpg", | ||
| "**/*.webp", | ||
| "$RESOURCE/**", | ||
| "**/*.riv", | ||
| "$HOME/**" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "plugins": { | ||
| "updater": { "active": false, "pubkey": "" }, | ||
| "deep-link": { | ||
| "desktop": { | ||
| "schemes": ["cap-desktop"] | ||
| } | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "createUpdaterArtifacts": true, | ||
| "targets": "all", | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/macos/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "resources": { | ||
| "assets/backgrounds/macOS/*": "assets/backgrounds/macOS/", | ||
| "assets/backgrounds/blue/*": "assets/backgrounds/blue/", | ||
| "assets/backgrounds/dark/*": "assets/backgrounds/dark/", | ||
| "assets/backgrounds/orange/*": "assets/backgrounds/orange/", | ||
| "assets/backgrounds/purple/*": "assets/backgrounds/purple/", | ||
| "../src/assets/rive/*.riv": "assets/rive/" | ||
| }, | ||
| "macOS": { | ||
| "dmg": { | ||
| "background": "assets/dmg-background.png", | ||
| "appPosition": { | ||
| "x": 180, | ||
| "y": 140 | ||
| }, | ||
| "applicationFolderPosition": { | ||
| "x": 480, | ||
| "y": 140 | ||
| } | ||
| }, | ||
| "frameworks": ["../../../target/native-deps/Spacedrive.framework"] | ||
| }, | ||
| "windows": { | ||
| "nsis": { | ||
| "headerImage": "assets/nsis-header.bmp", | ||
| "sidebarImage": "assets/nsis-sidebar.bmp", | ||
| "installerIcon": "icons/icon.ico" | ||
| }, | ||
| "wix": { | ||
| "upgradeCode": "79f4309d-ca23-54df-b6f9-826a1d783676", | ||
| "bannerPath": "assets/wix-banner.bmp", | ||
| "dialogImagePath": "assets/wix-dialog.bmp" | ||
| } | ||
| }, | ||
| "fileAssociations": [ | ||
| { | ||
| "ext": ["cap"], | ||
| "name": "Cap Project", | ||
| "mimeType": "application/x-cap-project", | ||
| "role": "Editor" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| "$schema": "../node_modules/@tauri-apps/cli/schema.json", | ||
| "build": { | ||
| "beforeBuildCommand": "pnpm build", | ||
| "beforeDevCommand": "pnpm dev:ui", | ||
| "devPath": "http://localhost:3001", | ||
| "distDir": "../dist" | ||
| }, | ||
| "package": { | ||
| "productName": "Cap", | ||
| "version": "../package.json" | ||
| }, | ||
| "tauri": { | ||
| "allowlist": { | ||
| "all": false, | ||
| "shell": { | ||
| "all": false, | ||
| "open": true | ||
| }, | ||
| "window": { | ||
| "all": false, | ||
| "close": true, | ||
| "hide": true, | ||
| "show": true, | ||
| "maximize": true, | ||
| "minimize": true, | ||
| "unmaximize": true, | ||
| "unminimize": true, | ||
| "startDragging": true | ||
| }, | ||
| "fs": { | ||
| "all": true, | ||
| "scope": ["$HOME/**", "$RESOURCE/**"] | ||
| }, | ||
| "path": { | ||
| "all": true | ||
| }, | ||
| "os": { | ||
| "all": true | ||
| }, | ||
| "dialog": { | ||
| "all": true | ||
| }, | ||
| "notification": { | ||
| "all": true | ||
| }, | ||
| "globalShortcut": { | ||
| "all": true | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "category": "DeveloperTool", | ||
| "copyright": "", | ||
| "deb": { | ||
| "depends": [] | ||
| }, | ||
| "externalBin": [], | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "identifier": "com.cap.desktop", | ||
| "longDescription": "", | ||
| "macOS": { | ||
| "entitlements": null, | ||
| "exceptionDomain": "", | ||
| "frameworks": [], | ||
| "providerShortName": null, | ||
| "signingIdentity": null | ||
| }, | ||
| "resources": [], | ||
| "shortDescription": "", | ||
| "targets": "all", | ||
| "windows": { | ||
| "certificateThumbprint": null, | ||
| "digestAlgorithm": "sha256", | ||
| "timestampUrl": "" | ||
| } | ||
| }, | ||
| "security": { | ||
| "csp": null | ||
| }, | ||
| "updater": { | ||
| "active": false | ||
| }, | ||
| "windows": [ | ||
| { | ||
| "fullscreen": false, | ||
| "height": 600, | ||
| "resizable": true, | ||
| "title": "Cap", | ||
| "width": 800 | ||
| } | ||
| ], | ||
| "systemTray": { | ||
| "iconPath": "icons/icon.png", | ||
| "iconAsTemplate": true | ||
| }, | ||
| "protocols": [ | ||
| { | ||
| "name": "cap-auth", | ||
| "schemes": ["cap-auth"] | ||
| }, | ||
| { | ||
| "name": "cap-deeplink", | ||
| "schemes": ["cap"] | ||
| } | ||
| ] | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Missing file associations configuration. The original config registered .cap file extension with:
"fileAssociations": [{
"ext": ["cap"],
"name": "Cap Project",
"mimeType": "application/x-cap-project",
"role": "Editor"
}]Without this, .cap files won't open with the app.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 1:114
Comment:
Missing file associations configuration. The original config registered `.cap` file extension with:
```json
"fileAssociations": [{
"ext": ["cap"],
"name": "Cap Project",
"mimeType": "application/x-cap-project",
"role": "Editor"
}]
```
Without this, `.cap` files won't open with the app.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+114
| { | ||
| "$schema": "https://schema.tauri.app/config/2", | ||
| "productName": "Cap - Development", | ||
| "identifier": "so.cap.desktop.dev", | ||
| "mainBinaryName": "Cap - Development", | ||
| "build": { | ||
| "beforeDevCommand": "pnpm localdev", | ||
| "devUrl": "http://localhost:3002", | ||
| "beforeBuildCommand": "pnpm turbo build --filter @cap/desktop", | ||
| "frontendDist": "../.output/public" | ||
| }, | ||
| "app": { | ||
| "macOSPrivateApi": true, | ||
| "security": { | ||
| "csp": "default-src 'self' ws: ipc: http://ipc.localhost; img-src 'self' asset: http://asset.localhost blob: data:; media-src 'self' asset: http://asset.localhost; script-src 'self' 'unsafe-eval' 'wasm-unsafe-eval'; style-src 'self' 'unsafe-inline'", | ||
| "assetProtocol": { | ||
| "enable": true, | ||
| "scope": [ | ||
| "$APPDATA/**", | ||
| "**/*.jpg", | ||
| "**/*.webp", | ||
| "$RESOURCE/**", | ||
| "**/*.riv", | ||
| "$HOME/**" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "plugins": { | ||
| "updater": { "active": false, "pubkey": "" }, | ||
| "deep-link": { | ||
| "desktop": { | ||
| "schemes": ["cap-desktop"] | ||
| } | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "createUpdaterArtifacts": true, | ||
| "targets": "all", | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/macos/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "resources": { | ||
| "assets/backgrounds/macOS/*": "assets/backgrounds/macOS/", | ||
| "assets/backgrounds/blue/*": "assets/backgrounds/blue/", | ||
| "assets/backgrounds/dark/*": "assets/backgrounds/dark/", | ||
| "assets/backgrounds/orange/*": "assets/backgrounds/orange/", | ||
| "assets/backgrounds/purple/*": "assets/backgrounds/purple/", | ||
| "../src/assets/rive/*.riv": "assets/rive/" | ||
| }, | ||
| "macOS": { | ||
| "dmg": { | ||
| "background": "assets/dmg-background.png", | ||
| "appPosition": { | ||
| "x": 180, | ||
| "y": 140 | ||
| }, | ||
| "applicationFolderPosition": { | ||
| "x": 480, | ||
| "y": 140 | ||
| } | ||
| }, | ||
| "frameworks": ["../../../target/native-deps/Spacedrive.framework"] | ||
| }, | ||
| "windows": { | ||
| "nsis": { | ||
| "headerImage": "assets/nsis-header.bmp", | ||
| "sidebarImage": "assets/nsis-sidebar.bmp", | ||
| "installerIcon": "icons/icon.ico" | ||
| }, | ||
| "wix": { | ||
| "upgradeCode": "79f4309d-ca23-54df-b6f9-826a1d783676", | ||
| "bannerPath": "assets/wix-banner.bmp", | ||
| "dialogImagePath": "assets/wix-dialog.bmp" | ||
| } | ||
| }, | ||
| "fileAssociations": [ | ||
| { | ||
| "ext": ["cap"], | ||
| "name": "Cap Project", | ||
| "mimeType": "application/x-cap-project", | ||
| "role": "Editor" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| "$schema": "../node_modules/@tauri-apps/cli/schema.json", | ||
| "build": { | ||
| "beforeBuildCommand": "pnpm build", | ||
| "beforeDevCommand": "pnpm dev:ui", | ||
| "devPath": "http://localhost:3001", | ||
| "distDir": "../dist" | ||
| }, | ||
| "package": { | ||
| "productName": "Cap", | ||
| "version": "../package.json" | ||
| }, | ||
| "tauri": { | ||
| "allowlist": { | ||
| "all": false, | ||
| "shell": { | ||
| "all": false, | ||
| "open": true | ||
| }, | ||
| "window": { | ||
| "all": false, | ||
| "close": true, | ||
| "hide": true, | ||
| "show": true, | ||
| "maximize": true, | ||
| "minimize": true, | ||
| "unmaximize": true, | ||
| "unminimize": true, | ||
| "startDragging": true | ||
| }, | ||
| "fs": { | ||
| "all": true, | ||
| "scope": ["$HOME/**", "$RESOURCE/**"] | ||
| }, | ||
| "path": { | ||
| "all": true | ||
| }, | ||
| "os": { | ||
| "all": true | ||
| }, | ||
| "dialog": { | ||
| "all": true | ||
| }, | ||
| "notification": { | ||
| "all": true | ||
| }, | ||
| "globalShortcut": { | ||
| "all": true | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "category": "DeveloperTool", | ||
| "copyright": "", | ||
| "deb": { | ||
| "depends": [] | ||
| }, | ||
| "externalBin": [], | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "identifier": "com.cap.desktop", | ||
| "longDescription": "", | ||
| "macOS": { | ||
| "entitlements": null, | ||
| "exceptionDomain": "", | ||
| "frameworks": [], | ||
| "providerShortName": null, | ||
| "signingIdentity": null | ||
| }, | ||
| "resources": [], | ||
| "shortDescription": "", | ||
| "targets": "all", | ||
| "windows": { | ||
| "certificateThumbprint": null, | ||
| "digestAlgorithm": "sha256", | ||
| "timestampUrl": "" | ||
| } | ||
| }, | ||
| "security": { | ||
| "csp": null | ||
| }, | ||
| "updater": { | ||
| "active": false | ||
| }, | ||
| "windows": [ | ||
| { | ||
| "fullscreen": false, | ||
| "height": 600, | ||
| "resizable": true, | ||
| "title": "Cap", | ||
| "width": 800 | ||
| } | ||
| ], | ||
| "systemTray": { | ||
| "iconPath": "icons/icon.png", | ||
| "iconAsTemplate": true | ||
| }, | ||
| "protocols": [ | ||
| { | ||
| "name": "cap-auth", | ||
| "schemes": ["cap-auth"] | ||
| }, | ||
| { | ||
| "name": "cap-deeplink", | ||
| "schemes": ["cap"] | ||
| } | ||
| ] | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Missing asset protocol configuration. The original had:
"security": {
"assetProtocol": {
"enable": true,
"scope": ["$APPDATA/**", "**/*.jpg", "**/*.webp", "$RESOURCE/**", "**/*.riv", "$HOME/**"]
}
}This is required for the app to access local assets. Per Cargo.toml:24, the app uses protocol-asset feature.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 1:114
Comment:
Missing asset protocol configuration. The original had:
```json
"security": {
"assetProtocol": {
"enable": true,
"scope": ["$APPDATA/**", "**/*.jpg", "**/*.webp", "$RESOURCE/**", "**/*.riv", "$HOME/**"]
}
}
```
This is required for the app to access local assets. Per `Cargo.toml:24`, the app uses `protocol-asset` feature.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
1
to
+114
| { | ||
| "$schema": "https://schema.tauri.app/config/2", | ||
| "productName": "Cap - Development", | ||
| "identifier": "so.cap.desktop.dev", | ||
| "mainBinaryName": "Cap - Development", | ||
| "build": { | ||
| "beforeDevCommand": "pnpm localdev", | ||
| "devUrl": "http://localhost:3002", | ||
| "beforeBuildCommand": "pnpm turbo build --filter @cap/desktop", | ||
| "frontendDist": "../.output/public" | ||
| }, | ||
| "app": { | ||
| "macOSPrivateApi": true, | ||
| "security": { | ||
| "csp": "default-src 'self' ws: ipc: http://ipc.localhost; img-src 'self' asset: http://asset.localhost blob: data:; media-src 'self' asset: http://asset.localhost; script-src 'self' 'unsafe-eval' 'wasm-unsafe-eval'; style-src 'self' 'unsafe-inline'", | ||
| "assetProtocol": { | ||
| "enable": true, | ||
| "scope": [ | ||
| "$APPDATA/**", | ||
| "**/*.jpg", | ||
| "**/*.webp", | ||
| "$RESOURCE/**", | ||
| "**/*.riv", | ||
| "$HOME/**" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "plugins": { | ||
| "updater": { "active": false, "pubkey": "" }, | ||
| "deep-link": { | ||
| "desktop": { | ||
| "schemes": ["cap-desktop"] | ||
| } | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "createUpdaterArtifacts": true, | ||
| "targets": "all", | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/macos/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "resources": { | ||
| "assets/backgrounds/macOS/*": "assets/backgrounds/macOS/", | ||
| "assets/backgrounds/blue/*": "assets/backgrounds/blue/", | ||
| "assets/backgrounds/dark/*": "assets/backgrounds/dark/", | ||
| "assets/backgrounds/orange/*": "assets/backgrounds/orange/", | ||
| "assets/backgrounds/purple/*": "assets/backgrounds/purple/", | ||
| "../src/assets/rive/*.riv": "assets/rive/" | ||
| }, | ||
| "macOS": { | ||
| "dmg": { | ||
| "background": "assets/dmg-background.png", | ||
| "appPosition": { | ||
| "x": 180, | ||
| "y": 140 | ||
| }, | ||
| "applicationFolderPosition": { | ||
| "x": 480, | ||
| "y": 140 | ||
| } | ||
| }, | ||
| "frameworks": ["../../../target/native-deps/Spacedrive.framework"] | ||
| }, | ||
| "windows": { | ||
| "nsis": { | ||
| "headerImage": "assets/nsis-header.bmp", | ||
| "sidebarImage": "assets/nsis-sidebar.bmp", | ||
| "installerIcon": "icons/icon.ico" | ||
| }, | ||
| "wix": { | ||
| "upgradeCode": "79f4309d-ca23-54df-b6f9-826a1d783676", | ||
| "bannerPath": "assets/wix-banner.bmp", | ||
| "dialogImagePath": "assets/wix-dialog.bmp" | ||
| } | ||
| }, | ||
| "fileAssociations": [ | ||
| { | ||
| "ext": ["cap"], | ||
| "name": "Cap Project", | ||
| "mimeType": "application/x-cap-project", | ||
| "role": "Editor" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| "$schema": "../node_modules/@tauri-apps/cli/schema.json", | ||
| "build": { | ||
| "beforeBuildCommand": "pnpm build", | ||
| "beforeDevCommand": "pnpm dev:ui", | ||
| "devPath": "http://localhost:3001", | ||
| "distDir": "../dist" | ||
| }, | ||
| "package": { | ||
| "productName": "Cap", | ||
| "version": "../package.json" | ||
| }, | ||
| "tauri": { | ||
| "allowlist": { | ||
| "all": false, | ||
| "shell": { | ||
| "all": false, | ||
| "open": true | ||
| }, | ||
| "window": { | ||
| "all": false, | ||
| "close": true, | ||
| "hide": true, | ||
| "show": true, | ||
| "maximize": true, | ||
| "minimize": true, | ||
| "unmaximize": true, | ||
| "unminimize": true, | ||
| "startDragging": true | ||
| }, | ||
| "fs": { | ||
| "all": true, | ||
| "scope": ["$HOME/**", "$RESOURCE/**"] | ||
| }, | ||
| "path": { | ||
| "all": true | ||
| }, | ||
| "os": { | ||
| "all": true | ||
| }, | ||
| "dialog": { | ||
| "all": true | ||
| }, | ||
| "notification": { | ||
| "all": true | ||
| }, | ||
| "globalShortcut": { | ||
| "all": true | ||
| } | ||
| }, | ||
| "bundle": { | ||
| "active": true, | ||
| "category": "DeveloperTool", | ||
| "copyright": "", | ||
| "deb": { | ||
| "depends": [] | ||
| }, | ||
| "externalBin": [], | ||
| "icon": [ | ||
| "icons/32x32.png", | ||
| "icons/128x128.png", | ||
| "icons/128x128@2x.png", | ||
| "icons/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "identifier": "com.cap.desktop", | ||
| "longDescription": "", | ||
| "macOS": { | ||
| "entitlements": null, | ||
| "exceptionDomain": "", | ||
| "frameworks": [], | ||
| "providerShortName": null, | ||
| "signingIdentity": null | ||
| }, | ||
| "resources": [], | ||
| "shortDescription": "", | ||
| "targets": "all", | ||
| "windows": { | ||
| "certificateThumbprint": null, | ||
| "digestAlgorithm": "sha256", | ||
| "timestampUrl": "" | ||
| } | ||
| }, | ||
| "security": { | ||
| "csp": null | ||
| }, | ||
| "updater": { | ||
| "active": false | ||
| }, | ||
| "windows": [ | ||
| { | ||
| "fullscreen": false, | ||
| "height": 600, | ||
| "resizable": true, | ||
| "title": "Cap", | ||
| "width": 800 | ||
| } | ||
| ], | ||
| "systemTray": { | ||
| "iconPath": "icons/icon.png", | ||
| "iconAsTemplate": true | ||
| }, | ||
| "protocols": [ | ||
| { | ||
| "name": "cap-auth", | ||
| "schemes": ["cap-auth"] | ||
| }, | ||
| { | ||
| "name": "cap-deeplink", | ||
| "schemes": ["cap"] | ||
| } | ||
| ] | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Missing macOS DMG and Windows installer customizations. The original config had custom images for:
- DMG background (
assets/dmg-background.png) - NSIS header/sidebar images
- WIX banner/dialog images
- Upgrade code for WIX installer
These are important for branding and proper installer behavior.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src-tauri/tauri.conf.json
Line: 1:114
Comment:
Missing macOS DMG and Windows installer customizations. The original config had custom images for:
- DMG background (`assets/dmg-background.png`)
- NSIS header/sidebar images
- WIX banner/dialog images
- Upgrade code for WIX installer
These are important for branding and proper installer behavior.
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1540
Changes
apps/desktop/src-tauri/tauri.conf.jsonDetails
Action: REPLACE_FILE
🤖 Generated by Opus Agent
Greptile Overview
Greptile Summary
This PR completely replaces the Tauri v2 configuration with an incompatible Tauri v1 configuration, which will break the desktop app build and runtime.
Critical Issues:
allowlistsyntax (removed in v2)app.macOSPrivateApi: true(required for NSPanel features perCargo.toml).capfile associationsso.cap.desktop.devtocom.cap.desktop(breaks existing installations)cap-desktoptocap-authandcap(may break existing links)What Was Intended:
The PR title suggests adding deeplink support, but the original config already had proper Tauri v2 deeplink configuration via
plugins.deep-link. This PR appears to have been generated by an automated tool that used outdated Tauri v1 templates.Recommendation:
Revert this PR entirely and keep the original Tauri v2 configuration. If deeplink schemes need to be modified, only update the
plugins.deep-link.desktop.schemesarray in the existing config.Confidence Score: 0/5
Important Files Changed
Sequence Diagram
sequenceDiagram participant User participant OS as Operating System participant App as Cap Desktop App participant Plugin as Tauri Deep Link Plugin participant Handler as Deep Link Handler User->>OS: Click deeplink (cap-desktop://...) OS->>App: Launch/Focus app with URL App->>Plugin: Register deep link schemes Plugin->>Plugin: Check scheme registration alt Tauri v2 (Correct) Plugin->>Handler: Parse URL with registered scheme Handler->>App: Route to appropriate view App->>User: Display content else Tauri v1 (This PR - Broken) Plugin->>Plugin: ERROR: Invalid config syntax Plugin->>App: Fail to register schemes App->>User: Deep link doesn't work end Note over App,Plugin: v2 uses plugins.deep-link config<br/>v1 uses tauri.protocols (incompatible)(2/5) Greptile learns from your feedback when you react with thumbs up/down!