[client-v2] Send parameters in request body #2713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion stream to proper handle resources.
…e flag - false by default
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
kavirajk
approved these changes
Jan 16, 2026
kavirajk
left a comment
kavirajk
left a comment
There was a problem hiding this comment.
LGTM (given my limited Java knowledge 😆 )
Left few minor comments. Approving to unblock
client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/CompressedEntity.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/ClientConfigProperties.java
Outdated
Show resolved
Hide resolved
client-v2/src/test/java/com/clickhouse/client/HttpTransportTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you, @kavirajk ! I appreciate your review! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Show resolved
Hide resolved
|
kavirajk
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
USE_HTTP_FORM_REQUEST_FOR_QUERYCloses #2324
Checklist
Delete items not relevant to your PR:
Note
Introduces optional multipart form requests for statement parameters and aligns HTTP/compression handling.
client.http.use_form_request_for_queryand builderuseHttpFormDataForQuery(...)Client.query(...): when enabled and params present, sends multipart; otherwise uses standard POST; inserts/query paths updated to new helper APIsHttpAPIClientHelper: newexecuteRequest(..., String)andexecuteMultiPartRequest(...); refactors URI/context/header builders; wraps entities without passingLZ4Factoryper-call; disables client compression for multipartCompressedEntity/LZ4Entity: correct unknown content length for compressed requests and improve stream lifecycletestMultiPartRequestintegration testWritten by Cursor Bugbot for commit b7eba36. This will update automatically on new commits. Configure here.