-
Notifications
You must be signed in to change notification settings - Fork 357
feat: Implement Feedback System & Navbar Integration #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Implement Feedback System & Navbar Integration #1361
Conversation
|
@roshankumar0036singh is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
|
@Avdhesh-Varshney plz review it |
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turn off your installed vs-code prettier or formatter tool. Then, use this command,
npm run formatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert these formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this formatting
| }) => { | ||
| const queryString = params | ||
| ? // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| `?${new URLSearchParams(params as any).toString()}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback should not be searchable through URL search parameter.
Just pass limit and skip values and encode them in api URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the formatting
| }} | ||
| > | ||
| <Badge> | ||
| <SupportAgentIcon /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move popper logic in navbar components folder. Just keep the icon button to be here.
Keep the code to be clean.
| reproduce_steps, | ||
| attachment_url, | ||
| attachment_public_id, | ||
| status: 'pending', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create enum for FEEDBACK_STATUS and also use the same in schema
|
|
||
| const feedbackRoutes = express.Router(); | ||
|
|
||
| // Route checks authentication and handles single file upload logic for 'attachment' field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to use upload multer middleware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update schema with enums
| "nodemailer": "^7.0.5", | ||
| "rate-limiter-flexible": "^7.3.0", | ||
| "resend": "^6.1.2", | ||
| "sanitize-html": "^2.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove this package.
Revert the changes of package.json and package-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this formatting
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@roshankumar0036singh Check this - on adding content in the textarea, instead of scroll with particular max height, it grows up |

Pull Requests Review Criteria
Caution
PRs that fail to meet these review standards will be automatically flagged and may be rejected by maintainers.
mainCloses: #1170
Describe the add-ons or changes you've made 📃
Introduced a complete Feedback & Issue Reporting System to allow users to report bugs, suggest features, or provide general feedback directly from the application.
🌟 New Features
Navbar Integration
feature-request.yml).Navbarfor seamless state management.Feedback Modal
useNotificationshook for consistent success/error feedback (removedreact-toastify).Backend Implementation
Feedbackmodel and schema in MongoDB.POST /api/feedback/submitaccepts a JSON payload.sanitize-htmlin favor of strict validation and clean architecture.🔧 Technical Improvements
FormDatareferences; implemented JSON-based file transfer (Base64).multer,react-toastifyremoved).Screenshots 📷