Xor8: remove previous serialization methods#52
Merged
lemire merged 2 commits intoFastFilter:masterfrom Jan 20, 2026
Merged
Conversation
Member
|
@vprus Could you just deprecate it instead ? So we don't break existing code ? |
Contributor
Author
|
I can, but is there evidence this code is used? Xor8 iself is documented as experimental. |
Member
None as far as I can tell, but it is arguably easier to deprecate than to delete. https://www.baeldung.com/java-deprecated I have just recently added a note to the effect that it is experimental. The implementation is ok, but it is certainly not battle tested. |
Contributor
Author
|
Ok, updated to use @deprecated. |
Member
|
Yeah. So this is super safe now. We can delete it later after a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #47 added serialization method to the Xor family of filters.
However, Xor8 already had two serialization methods, and they used a different format (without encoded length of the fingerprint array). Having two serialization methods with a different format is just asking for trouble, so this PR
removes the historic method. Test appear to still work.