-
Notifications
You must be signed in to change notification settings - Fork 54
use java 11 instead of java 9 + basic compilation #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4356,4 +4356,68 @@ public Date getSamuchLeMinchaKetana16Point1Degrees() { | |
| public Date getSamuchLeMinchaKetana72Minutes() { | ||
| return getSamuchLeMinchaKetana(getAlos72(), getTzais72(), true); | ||
| } | ||
|
|
||
| public Date getSofZmanShmaKolEliyahu() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getSofZmanShmaFixedLocal() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getSofZmanTfilaFixedLocal() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosRT13Point24Degrees() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosRT58Point5Minutes() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosRT13Point5MinutesBefore7Point083Degrees() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosRT2Stars() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosYereim18Minutes() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosYereim3Point05Degrees() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosYereim16Point875Minutes() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosYereim2Point8Degrees() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosYereim13Point5Minutes() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getBainHasmashosYereim2Point1Degrees() { | ||
| return null; | ||
| } | ||
|
|
||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All of the methods above were spelled Hasmasos. There was already renamed Hashmashos (adding the H back in). If test cases broke for these, we should tweak the spelling to the version with an H. |
||
| public Date getTzaisGeonim3Point65Degrees() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getTzaisGeonim3Point676Degrees() { | ||
| return null; | ||
| } | ||
|
|
||
| public Date getSofZmanTfilahAteretTorah() { | ||
| return null; | ||
| } | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @elijulian , The above three were intended for removal as per the deprecation warning. |
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,12 @@ | ||
| package com.kosherjava.zmanim.hebrewcalendar; | ||
|
|
||
| import com.kosherjava.zmanim.ComplexZmanimCalendar; | ||
| import com.kosherjava.zmanim.util.AstronomicalCalculator; | ||
| import com.kosherjava.zmanim.ComprehensiveZmanimCalendar; | ||
| import com.kosherjava.zmanim.util.GeoLocation; | ||
|
|
||
| import java.io.*; | ||
| import java.io.BufferedWriter; | ||
| import java.io.File; | ||
| import java.io.FileWriter; | ||
| import java.io.IOException; | ||
|
Comment on lines
+6
to
+9
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @elijulian , were these imports really used? Was this due to the JDK update? |
||
| import java.time.LocalDate; | ||
| import java.util.*; | ||
|
|
||
|
|
@@ -17,7 +19,7 @@ public static void main(String[] args) throws IOException { | |
| JewishCalendar cal = new JewishCalendar(current); | ||
| GregorianCalendar gregorian = new GregorianCalendar(current.getYear(), current.getMonthValue() - 1, current.getDayOfMonth()); | ||
| JewishDate date = new JewishDate(current); | ||
| ComplexZmanimCalendar zcal = new ComplexZmanimCalendar(new GeoLocation("Lakewood, NJ", 40.096, -74.222, 29.02, TimeZone.getTimeZone("America/New_York"))); | ||
| ComprehensiveZmanimCalendar zcal = new ComprehensiveZmanimCalendar(new GeoLocation("Lakewood, NJ", 40.096, -74.222, 29.02, TimeZone.getTimeZone("America/New_York"))); | ||
| List<FullCalendar> calendars = new ArrayList<>(); | ||
| List<FullZmanim> zmanim = new ArrayList<>(); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were intended for removal. They had forRemoval=true. We should not add them back in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these methods in order to allow the test to compile, there were referenced to all these methods...