MDEV-36725 Fix innodb_ctype_ldml test in view-protocol mode#4603
Open
FarihaIS wants to merge 1 commit intoMariaDB:10.6from
Open
MDEV-36725 Fix innodb_ctype_ldml test in view-protocol mode#4603FarihaIS wants to merge 1 commit intoMariaDB:10.6from
FarihaIS wants to merge 1 commit intoMariaDB:10.6from
Conversation
The test innodb.innodb_ctype_ldml was failing in view-protocol mode due to different column naming behavior for complex expressions. Without explicit column aliases, view-protocol mode generates automatic names (Name_exp_1, Name_exp_2) while normal mode uses the full expression as the column name. Add explicit column aliases to SELECT statements in innodb_ctype_ldml to ensure consistent column names across both normal and view-protocol modes. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test
innodb.innodb_ctype_ldmlwas failing in view-protocol mode due to different column naming behavior for complex expressions.Without explicit column aliases, view-protocol mode generates automatic names (
Name_exp_1,Name_exp_2) while normal mode uses the full expression as the column name.Add explicit column aliases to
SELECTstatements ininnodb_ctype_ldmlto ensure consistent column names across both normal and view-protocol modes.Release Notes
N/A
How can this PR be tested?
Execute the test
innodb_ctype_ldmlin the innodb suite using--view-protocol.Before the fix
The test fails due to result length mismatches.
After the fix
The test passes.
Basing the PR against the correct MariaDB version
Copyright
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.