fix: Disallow using unconnected accounts in MultichainRouter #3837
+61
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow using unconnected account Snaps for address resolution in MultichainRouter, additionally ensure requests are only routed to connected accounts following resolution.
Note
Medium Risk
Medium risk because it changes account selection/routing logic for signing requests, which can affect which account is used or cause new request rejections if
connectedAddressesis incorrect or missing.Overview
Prevents
MultichainRouterfrom routing account-Snap signing requests to accounts that are not in the request’sconnectedAddresses, including during address resolution.#getSnapAccountIdnow filters candidate accounts to those connected first, uses a connected Snap for resolution, and selects only from the connected subset (otherwise throwsinvalidParamswith "No available account found for request."). A new test covers the failure case when no connected accounts are provided.Written by Cursor Bugbot for commit 1eaf930. This will update automatically on new commits. Configure here.