move ruff configuration into pyproject.toml #806
+29
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves
ruffconfiguration intopyproject.toml.I noticed this project has a
.flake8, but doesn't actually runflake8directly... I think the configuration in that.flake8is getting ignored (based on https://docs.astral.sh/ruff/configuration/, I don't believeruffreads.flake8files).This PR ensures
ruffrespects this project's configuration. Any other changes were made automatically bypre-commithooks.Issue
N/A
Notes for Reviewers
How I chose these checks
I only selected checks that
flake8would run.I think it'd be worthwhile to expand this in the future, especially with
(B) flake8-bugbearand(PERF) perflint. I'll leave that to you all in a follow-up if you'd like. Here's a list of rules I like to use in Python projects: https://github.com/jameslamb/pydistcheck/blob/3bf39fd2f0c9328e519b8892b6dfde029381d7a0/pyproject.toml#L133Checklist
Summary by CodeRabbit
Chores
Documentation
Style
✏️ Tip: You can customize this high-level summary in your review settings.