Draft
Conversation
Member
|
Thanks @danbjoseph 👍 I think this might have some issues with the build command So the automated build would hang here. |
Collaborator
Author
|
ah, you're right, i completely forgot about that piece. i'll look into if it's possible to get around that securely. |
Contributor
|
@danbjoseph -- any solution for doing this securely? |
Collaborator
Author
|
should be possible with https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions |
Contributor
|
Makes sense. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storing all the translation files in the repo doesn't seem to be adding much value, and ends up with LOTS of changed files every time there's a change and we want to update all the languages. this PR takes those files out of the repo, and pulls the language strings down from Transifex during the build process. currently, in order to push changes that have occurred up to Transifex for translation, we still need to run:
but that could be changed to occur during the build process as well.