Tags #32
Open
Tags #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudoShiba
commented
Dec 14, 2025
sudoShiba
commented
icons not working yet
kwikenkwak
reviewed
Feb 11, 2026
kwikenkwak
left a comment
kwikenkwak
left a comment
There was a problem hiding this comment.
Ik ga eerlijk zijn, ik ken echt niet veel van swift, dus ik kan niet veel zeggen over code quality. Ik hoop gewoon dat dit niet kan zorgen voor vage crashes haha. En ik kan het zelf ook niet op een ios device testen dus ik vertrouw erop dat sizing/coloring nu helemaal goed zit
|
|
||
| #### Custom Tag Icons | ||
|
|
||
| The library includes built-in icon support for: `bed`, `alert`, `fail`, `success`, `drink`. These tags will display as icons instead of text. If you add them to your app's Assets.xcassets |
Comment on lines
+222
to
+241
| To add your own custom tag icons: | ||
|
|
||
| 1. **Add to your app's Asset Catalog** (Recommended): | ||
| - Open your app's `Assets.xcassets` | ||
| - Add a new Image Set for each icon (e.g., "meeting", "personal") | ||
| - Add PNG or PDF images to the image sets | ||
| - Use the image set name as the tag name | ||
|
|
||
| 2. **Using PNG/PDF files**: | ||
| - Add PNG or PDF files to your app bundle | ||
| - Name them to match your tag names (e.g., "meeting.png") | ||
| - The library will automatically find and use them | ||
|
|
||
| The library searches for icons in this order: | ||
| 1. Main app bundle's Asset Catalog | ||
| 2. Framework bundle's Asset Catalog | ||
| 3. Framework's Assets/tags directory (PNG/PDF) | ||
|
|
||
| Tags without matching icons will be displayed as text pills with the event color. | ||
|
|
There was a problem hiding this comment.
Wat met die pdf files? Miss dit gewoon of fixen of weghalen
Comment on lines
138
to
162
| @@ -131,13 +152,22 @@ open class EventData: NSObject, NSCoding { | |||
| let dColor = coder.decodeObject(forKey: EventDataEncoderKey.color) as? UIColor { | |||
| let dGradientLayer = coder.decodeObject(forKey: EventDataEncoderKey.gradientLayer) as? CAGradientLayer | |||
| let dAllDay = coder.decodeBool(forKey: EventDataEncoderKey.allDay) | |||
| let dTagNames = coder.decodeObject(forKey: EventDataEncoderKey.tags) as? [String] ?? [] | |||
| let dTagColors = coder.decodeObject(forKey: "tagColors") as? [UIColor] ?? [] | |||
| // Reconstruct EventTag objects from decoded arrays | |||
| var eventTags: [EventTag] = [] | |||
| for i in 0..<dTagNames.count { | |||
| let color = i < dTagColors.count ? dTagColors[i] : UIColor.white | |||
| eventTags.append(EventTag(name: dTagNames[i], color: color)) | |||
| } | |||
There was a problem hiding this comment.
Waaarom encoden we dat eigenlijk naar arrays? Want er staat 'backwards compatiblity' maar da is toch helemaal ni relevant hier? Kdenk dat dit wel wat mooier/korter kan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.