Additional info on state changes of buttons#59
Closed
sven-bock wants to merge 3 commits intoRethinkRobotics:masterfrom
Closed
Additional info on state changes of buttons#59sven-bock wants to merge 3 commits intoRethinkRobotics:masterfrom
sven-bock wants to merge 3 commits intoRethinkRobotics:masterfrom
Conversation
…camera is not opened. This is useful to check, if a camera is opened or closed.
…wheel" and the button id or wheel position is sent in the arguments. This is useful to use one callback for all buttons.
…e. Useful for common callbacks
Contributor
|
Great pull request @sven-bock! I'll review it and get back to you. In the meantime could you rebase and PR into |
Contributor
|
superseded by #62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DigitalIO and Navigators
This little improvement enables you to see which buttons was pressed in your callback function.
Therefore you need only one callback function for all your buttons.
e.g.:
Camera
The current implementation raises an exception, if the camera is currently closed. I think it is useful in the camera controller to check, if the camera is opened or closed. Also in the past the service call to the camera list yielded all 3 cameras, which is not the case any more. Therefore I recommend to change the condition of the if in the init