always add current poisition as the first point in trajectory points#73
Open
k-okada wants to merge 2 commits intoRethinkRobotics:masterfrom
Open
always add current poisition as the first point in trajectory points#73k-okada wants to merge 2 commits intoRethinkRobotics:masterfrom
k-okada wants to merge 2 commits intoRethinkRobotics:masterfrom
Conversation
This was referenced Jul 16, 2016
k-okada
pushed a commit
to k-okada/jsk_robot
that referenced
this pull request
Jul 19, 2016
k-okada
added a commit
to k-okada/jsk_robot
that referenced
this pull request
Jul 19, 2016
This was referenced Jul 19, 2016
k-okada
added a commit
to jsk-ros-pkg/jsk_robot
that referenced
this pull request
Jul 19, 2016
Contributor
|
Yep. This change makes sense. I considered this behavior in the past as well, but never followed through. I'd be willing to merge if you retarget at the |
k-okada
force-pushed
the
always_add_first_point
branch
from
3386356 to
e1484b8
Compare
Member
Author
|
ok, rebased |
wkentaro
reviewed
Sep 23, 2016
| dimensions_dict = self._determine_dimensions(trajectory_points) | ||
|
|
||
| if num_points == 1: | ||
| if num_points >= 1 and trajectory_points[0].time_from_start.to_sec() > 0: |
Member
There was a problem hiding this comment.
This can be following? because it returns when num_points == 0.
if trajectory_points[0].time_from_start.to_sec() > 0:
Member
Author
sorry, I missed this commend. Created new pull request -> #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, currently, joint trajectoy action server behavios
if points is 1, add current position to the first point in trajectory points
others, assuming that user set current position to the first point in trajectory points
Is there any reason to do this? why not always put first point in trajectory points ?
c.f #55, #55