fix: resolve broken message insertion logic#1123
Open
deepak0x wants to merge 1 commit intoRocketChat:developfrom
Open
fix: resolve broken message insertion logic#1123deepak0x wants to merge 1 commit intoRocketChat:developfrom
deepak0x wants to merge 1 commit intoRocketChat:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect message insertion behavior and removes inconsistencies in how messages are stored and rendered across the application.
Closes #1082
Solution
This PR standardizes message storage across the application by using a single, consistent order:
Ascending order (Oldest → Newest) everywhere.
Key Changes
Updated
insertMessageThe insertion logic now supports ascending lists by finding the correct index where the next message is newer:
Updated
messageStoreThe
setMessagesaction now reverses the server response (which is descending by default) before storing it, ensuring all messages in the store are ascending.