der: clarify writer: add pretty-printing DER hex with comments#1892
Open
dishmaker wants to merge 3 commits intoRustCrypto:masterfrom
Open
der: clarify writer: add pretty-printing DER hex with comments#1892dishmaker wants to merge 3 commits intoRustCrypto:masterfrom
dishmaker wants to merge 3 commits intoRustCrypto:masterfrom
Conversation
tarcieri
reviewed
Jul 18, 2025
bafcc37 to
78f1035
Compare
78f1035 to
6abcbf8
Compare
Contributor
Author
|
I removed the dependency on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1835
I made sure it does not add any runtime overhead, even when using the
"clarify"feature.This PR is initial support.
In future I'd like to add
Sequencefield names in comments, as well as OID pretty-printing.Examples
Rust:
XML:
rusticata/asn1-rspretty-printer: rusticata/asn1-rs#25