-
Notifications
You must be signed in to change notification settings - Fork 16
Support libavif loop count #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
634f480
Support libavif loop count
dreampiggy 9273aef
Update the calculation for quality/qualityAlpha because of deprecation
dreampiggy bc5f74d
Support thumbnail encoding
dreampiggy 7c7d8fc
Upgrade the encode ICCData logic
dreampiggy 2b09dfc
Update readme
dreampiggy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| github "SDWebImage/SDWebImage" ~> 5.10 | ||
| github "SDWebImage/libavif-Xcode" >= 0.11.2-rc1 | ||
| github "SDWebImage/libavif-Xcode" >= 1.0.0 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shadowed variable
scaledSizeon line 342 duplicates the computation from line 339.Inside the
ifblock,CGSize scaledSizeis re-declared with the exact same expression already evaluated three lines above. This shadows the outerscaledSizeand is dead/redundant code. Remove the inner declaration so the block uses the already-computed value.Additionally, the
asserton lines 343–344 uses strict<. With floating-point rounding in aspect-ratio-preserving scaling, one dimension could conceivably equal the original, causing a debug-mode abort. Consider<=or removing the asserts in favor of a graceful early-return.🔧 Proposed fix — remove duplicate declaration
// Check if need to scale pixel size CGSize scaledSize = [SDImageCoderHelper scaledSizeWithImageSize:CGSizeMake(width, height) scaleSize:maxPixelSize preserveAspectRatio:YES shouldScaleUp:NO]; if (!CGSizeEqualToSize(scaledSize, CGSizeMake(width, height))) { // Thumbnail Encoding - CGSize scaledSize = [SDImageCoderHelper scaledSizeWithImageSize:CGSizeMake(width, height) scaleSize:maxPixelSize preserveAspectRatio:YES shouldScaleUp:NO]; - assert(scaledSize.width < width); - assert(scaledSize.height < height); + assert(scaledSize.width <= width); + assert(scaledSize.height <= height); avifScalingMode scale; scale.horizontal.n = (int)scaledSize.width; scale.horizontal.d = (int)width;🤖 Prompt for AI Agents