a new dedicated workqueue only for async write commit, and block clients while committing changes#741
Open
yzhao244 wants to merge 1 commit intoSnapchat:async_flashfrom
Open
Conversation
…nts while commiting changes
Author
|
@JohnSully Hi John, this PR is like a continuation of async commit which includes a specific workqueue for async commit and client blocks. @paulmchen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Ankita's initial async commit code, this PR contains a few new enhancements are introduced in this MR. Please review to see if the implementation makes sense