Adding 'sb' instruction to fastlock_lock() for ARM v8.5 onward#911
Open
salvatoredipietro wants to merge 1 commit intoSnapchat:mainfrom
Open
Adding 'sb' instruction to fastlock_lock() for ARM v8.5 onward#911salvatoredipietro wants to merge 1 commit intoSnapchat:mainfrom
salvatoredipietro wants to merge 1 commit intoSnapchat:mainfrom
Conversation
Author
|
Can anyone take a look to this and provide some initial feedback, please? |
Author
|
any initial feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to propose this optimization for ARM architecture that, at runtime, it switches to SB instruction if supported by the system. In general, ISB instruction has lower cost for the CPU than"YIELD" on ARM64. Moreover, SB (Speculation Barrier) is a modern barrier which is available from armv8.5a. It achieves the same result as issuing ISB, but instead of flushing the CPU it does so by serializing older instructions to be non-speculative before it completes. This is less disruptive than an "isb" to high performance CPUs.
We already saw positive improvements on MySQL server (mysql/mysql-server#611) and Folly (facebook/folly#2390).