Fix: Add Fedora/RHEL support to Linux dev setup#41
Open
VivekLumbhani wants to merge 1 commit intoSnapchat:mainfrom
Open
Fix: Add Fedora/RHEL support to Linux dev setup#41VivekLumbhani wants to merge 1 commit intoSnapchat:mainfrom
VivekLumbhani wants to merge 1 commit intoSnapchat:mainfrom
Conversation
- Auto-detect package manager (apt/dnf/yum) - Map package names for different distros - Handle libtinfo5 installation for both Ubuntu and Fedora - Fix Java package names for different distros - Fixes Snapchat#38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #34 where iOS-only developers were forced to install Android Studio and set up ANDROID_NDK_HOME, even though they don't need Android dependencies.
Problem
Currently,
valdi_initialize_workspace()unconditionally registers Android dependencies by calling_register_android_deps(). This causes the build to fail with:This is frustrating for developers who only want to build iOS apps and don't want to install the entire Android toolchain.
Solution
Added an
enable_androidparameter tovaldi_initialize_workspace()with smart defaults:enable_android = None(default): Auto-detects based ontarget_platformenable_android = False: Explicitly skips Android dependenciesenable_android = True: Explicitly enables Android dependenciesChanges Made
Code Changes
bzl/workspace_init.bzl:enable_androidparameter tovaldi_initialize_workspace()target_platform_register_android_deps()conditionalDocumentation
docs/[your-doc-file].md: (adjust based on what you actually updated)enable_android = FalseUsage Examples
iOS-only project (no Android Studio needed)
Android-only project
Multi-platform project (default behavior unchanged)
valdi_initialize_workspace()Testing
Tested by:
enable_android = FalseBackward Compatibility
✅ Fully backward compatible - existing WORKSPACE files will continue to work exactly as before. The default behavior is unchanged for multi-platform projects.
Fixes
Closes #34
Checklist
Note to reviewers: This is a quality-of-life improvement that removes unnecessary setup friction for iOS developers while maintaining full backward compatibility.