fix: avoid exposing browser-only ESM build via module #237#259
Open
lelnotwellyet wants to merge 1 commit intoWalletConnect:masterfrom
Open
fix: avoid exposing browser-only ESM build via module #237#259lelnotwellyet wants to merge 1 commit intoWalletConnect:masterfrom
lelnotwellyet wants to merge 1 commit intoWalletConnect:masterfrom
Conversation
|
All contributors have signed the CTA ✍️ ✅ |
Author
|
I have read the CTA Document and I hereby sign the CTA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modulewas pointing to a browser-only ESM build that referencesindexedDB,which causes Node.js to throw
ReferenceError: indexedDB is not definedinnon-browser environments.
This change removes the
moduleentry to ensure:Note:
moduleis valid for Node.js when it points to a Node-safe ESM build.In this package it currently resolves to a browser-only output, so removing
the entry avoids the runtime crash until a Node-compatible ESM build exists.
Build verification is covered by CI.