[TASK] first attempt to reduce NPM need bu using the Core nightly bui…#246
Open
ramonfincken wants to merge 1 commit intoWordPress:masterfrom
Open
[TASK] first attempt to reduce NPM need bu using the Core nightly bui…#246ramonfincken wants to merge 1 commit intoWordPress:masterfrom
ramonfincken wants to merge 1 commit intoWordPress:masterfrom
Conversation
…ld as source of truth for CSS and JS files
Member
|
Perhaps I'm missing something. But why can't the test runner just use the https://github.com/WordPress/WordPress repository instead of the nightly? Using the nightly loses a level of fidelity because you can't control which commit is tested. But the WordPress SVN repository is updated by the build server after every commit to wordpress-develop and mirrored here to GitHub. The only challenge there is a search would need to be performed to find the corresponding changeset. |
Author
|
The point is to copy the nightly JS/CSs files, not the PHP ones. But hold on, i will try using another path. |
Author
|
Thanks for your talk at WordCamp by the way :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first attempt to reduce NPM need bu using the Core nightly build as source of truth for CSS and JS files