chore: 553: Addressed PR comments from Pull request 564.

[Sathyvs]

Changes related to PushNotificationConfig pagination feature

Description

Addresses PR comments from PR 564

Fixes #553 🦕

[gemini-code-assist]

Summary of Changes

Hello @Sathyvs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the PushNotificationConfig pagination functionality by making the maximum page size configurable and improving the robustness of page token validation. It also includes a minor adjustment to a core dependency's scope and introduces a flexible way to manage default configurations in test environments. These changes collectively improve the maintainability, configurability, and error handling of the pagination feature.

Highlights

• Configurable Max Page Size: Introduced a configurable maximum page size for push notification configuration listings, defaulting to 100 and allowing overrides via the a2a.push-notification-config.max-page-size property.
• Improved Invalid Page Token Handling: The system now explicitly throws an InvalidParamsError when an invalid pageToken format is provided, instead of silently ignoring it and starting from the beginning.
• Dependency Scope Adjustment: The quarkus-arc dependency in server-common was promoted from test scope to a compile-time dependency, indicating its broader usage within the application.
• Test-Specific Default Configuration: A mechanism was added to allow overriding default configuration properties specifically for testing environments, using the a2a.defaults.resource property.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses previous review comments by refactoring the pagination logic in JpaDatabasePushNotificationConfigStore to be cleaner and more robust. Key improvements include making the maximum page size configurable, validating page tokens more strictly, and updating tests to cover these changes. The code is well-structured, and the new test cases are thorough. I have a couple of suggestions to improve exception handling and code style.

[Sathyvs]

@kabir @ehsavoie a quick review pls ?

[Sathyvs]

@kabir @ehsavoie pls check this one, I will create another PR to have 2 separate operations for list and get

[ehsavoie]

@Sathyvs may you fix Gemini 's comments. I will take a deeper look today.

[ehsavoie]

I'm wondering if we should change this behaviour as i can see that the pagesize should be provided by the ListTaskPushNotificationConfigRequest according to https://github.com/a2aproject/A2A/blob/main/specification/grpc/a2a.proto#L832C9-L832C46 so this should be handled at a higher level in my humble opinion

[ehsavoie]

@kabir @jmesnil @s I would like your opinion on this.

[Sathyvs]

@ehsavoie thank you for bringing this up. I agree to your point, but per the spec here https://a2a-protocol.org/latest/specification/#319-list-push-notification-configs It says the page_size and page_token are not mandatory. Also the spec doesn't mandate a value range, so if a request is made with page_size as Integer.MAX_VALUE, we cannot support that, and this configuration acts as a ceiling value for the size. We can increase it if 100 is too less.
Also this is just following the same way how JPATaskStore is written today. So we can discuss what is the best approach for both tasks and push notifications, and based on the decision, I can refactor both of them to keep them consistent.
wdyt ?