GH-10: Add basic checks into pre-commit-config#435
Merged
lidavidm merged 7 commits intoapache:mainfrom Dec 26, 2024
Merged
Conversation
Member
|
Could you add https://github.com/apache/arrow-go/blob/main/.editorconfig for shfmt? |
Member
Author
|
Good catch, thank you. |
kou
reviewed
Dec 2, 2024
lidavidm
reviewed
Dec 12, 2024
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Do we want to revert the YAML changes since we aren't using yamlfmt?
Member
Author
|
I see. I thought the reformatting of indentation made sense. |
Member
Author
|
Reverted changes in YAML files |
lidavidm
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Fixes #11
Removed gh 12 now