GH-734: Improve CompositeJdbcConsumer error handling and add unit tests#778
Open
Odin-BN wants to merge 1 commit intoapache:mainfrom
Open
GH-734: Improve CompositeJdbcConsumer error handling and add unit tests#778Odin-BN wants to merge 1 commit intoapache:mainfrom
Odin-BN wants to merge 1 commit intoapache:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Author
|
@github-actions please add label: bug-fix |
Author
|
Hi @lidavidm ! Would you mind adding the "bug-fix" label to this PR please? I thought maybe the github actions bot could add it automatically with a message, as assigning the issue but it seems that not. Thanks in advance! |
Member
|
Yeah, usually I label it when I review - maybe I should adjust it so that it's a reminder to reviewers (I originally thought the PR author could add labels...) |
lidavidm
requested changes
Jun 2, 2025
Member
lidavidm
left a comment
There was a problem hiding this comment.
I'm not sure this addresses the original bug report, which is about when getType throws when we try to get arrowType. If anything, the right fix is to just get the type directly from the vector, rather than indirecting through getMinorType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
This PR improves error handling in 'CompositeJdbConsumer' by safely handling null 'ValueVector' and 'ResultSet' values to prevent 'NullPointerException', and return the intended 'JdbcConsumerException'.
How was this tested?
Added two unit tests in 'CompositeJdbcConsumerTest':
All tests pass after the change.
Closes #734