[feature](lineage) Support lineage when ctas, insert into and insert overwrite #60122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seawinde
requested review from
CalvinKirs,
dataroaring and
morningman
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31117 ms |
TPC-DS: Total hot run time: 173439 ms |
ClickBench: Total hot run time: 26.8 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
seawinde
force-pushed
the
lineage_feature
branch
from
81e42fc to
022d0b6
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31075 ms |
TPC-DS: Total hot run time: 172742 ms |
morrySnow
reviewed
Jan 26, 2026
| if (!LineageUtils.isSameParsedCommand(executor, currentHandleClass)) { | ||
| return; | ||
| } | ||
| if (!isLineagePluginConfigured()) { |
Contributor
There was a problem hiding this comment.
we should check this one at first
| && FeConstants.INTERNAL_DB_NAME.equalsIgnoreCase(dbName); | ||
| } | ||
|
|
||
| private static Map<String, Map<String, String>> collectExternalCatalogProperties(LineageInfo lineageInfo) { |
Contributor
There was a problem hiding this comment.
why need catalog properties?
Contributor
Author
There was a problem hiding this comment.
because some lineage plugin need external catalog property such as uri and so on
| package org.apache.doris.nereids.lineage; | ||
|
|
||
| /** | ||
| * Lineage event wrapping lineage info for plugins. |
Contributor
Author
There was a problem hiding this comment.
lineage info is enough, remove the lineage event
| lineagePlugins = Collections.emptyList(); | ||
| } | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("update lineage plugins. num: {}", lineagePlugins.size()); |
| for (Plugin plugin : lineagePlugins) { | ||
| try { | ||
| AbstractLineagePlugin lineagePlugin = (AbstractLineagePlugin) plugin; | ||
| if (!lineagePlugin.eventFilter()) { |
Contributor
There was a problem hiding this comment.
eventFilter do not need Event as parameter?
Contributor
Author
There was a problem hiding this comment.
this judge by the config parm in fe.conf, which can be get by Config.xxx，so not need parameter now
Comment on lines
136
to
140
| LineageInfo lineageInfo = lineageEvent.getLineageInfo(); | ||
| if (lineageInfo == null) { | ||
| LOG.warn("lineage info is null for event {}, skip", getQueryId(lineageEvent)); | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
move it as the first step
| return; | ||
| } | ||
| CascadesContext cascadesContext = getCascadesContext(); | ||
| getStatementContext().getPlannerHooks().forEach(hook -> hook.beforeAnalyze(this)); |
Contributor
There was a problem hiding this comment.
if insert values does not generate lineage event, why add hoot here?
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32857 ms |
ClickBench: Total hot run time: 28.22 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32296 ms |
ClickBench: Total hot run time: 28.34 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32926 ms |
ClickBench: Total hot run time: 28.23 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31639 ms |
ClickBench: Total hot run time: 28.71 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31798 ms |
ClickBench: Total hot run time: 28.18 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Code Flow
Design
Example (JOIN)
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)