I ran `cargo fmt on this project.#12
Open
martinfrances107 wants to merge 1 commit intoaskanium:masterfrom
Open
I ran `cargo fmt on this project.#12martinfrances107 wants to merge 1 commit intoaskanium:masterfrom
cargo fmt on this project.#12martinfrances107 wants to merge 1 commit intoaskanium:masterfrom
Conversation
There is no change in functionality, I think this makes the code more readable Also I added a github action to enforce the formatting policy. I think this a good thing to do, as all debate about which code layout looks best gets reduced to "What does cargo fmt" say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love this module , it is really useful
There is no change in functionality, I think this makes the code more readable Also I added a github action to enforce the formatting policy.
I think this a good thing to do, as all debate about which code layout looks best gets reduced to "What does cargo fmt" say.
It is a common operation to configure you IDE to run cargo fmt on every "save"
I am about to file another issue where to function signature forces the creation of a new object .. rather than passing a slice by reference, so this is just a preliminary step