Skip to content

Conversation

@stephentoub
Copy link
Contributor

Description

Update IChatClient with support from latest bedrock runtime / M.E.AI

Motivation and Context

  • Adds support for multi-modal tool returns.
  • Adds support for citations with URIs.
  • Adds a ton of tests verifying IChatClient behavior around the underlying IAmazonBedrockRuntime.

Testing

The PR includes a lot of tests for the IChatClient implementation, which previously had few-to-none.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@dscpinheiro dscpinheiro changed the base branch from main to development December 3, 2025 01:26
@dscpinheiro dscpinheiro self-requested a review December 3, 2025 18:28
@AlexDaines AlexDaines self-requested a review December 3, 2025 18:28
normj and others added 2 commits December 10, 2025 09:29
- Adds support for multi-modal tool returns.
- Adds support for citations with URIs.
- Adds a ton of tests verifying IChatClient behavior around the underlying IAmazonBedrockRuntime.
@normj
Copy link
Member

normj commented Jan 15, 2026

@stephentoub I refreshed your branch and added a devconfig for the change log.

There is a class of unit tests failing though converting the ChatOptions.AdditionalProperties to ConverseRequest.AdditionalModelRequestFields. Looking at the code for BedrockChatClient.GetResponseAsync I don't see any code to handle the conversion. Is there a commit missing from your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants