fix: update inference processor from 'inf2' to 'neuronx' #5488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version generates the following image tag for 0.4.1: 0.10.2-inf2-py310-sdk2.26.0-ubuntu22.04 But it should be: 0.10.2-neuronx-py310-sdk2.26.0-ubuntu22.04
dacorvo
had a problem deploying
to
manual-approval
GitHub Actions
Error
There was a problem hiding this comment.
Pull request overview
This PR fixes the inference processor name for the HuggingFace vLLM NeuronX image configuration, changing it from 'inf2' to 'neuronx' to ensure the correct image tag format is generated.
Changes:
- Updated the processor name from 'inf2' to 'neuronx' in the inference configuration
- Updated the container_version key from 'inf2' to 'neuronx' to match the processor change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dacorvo
requested a deployment
to
manual-approval
GitHub Actions
Waiting
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version generates the following image tag for version
0.4.1:0.10.2-inf2-py310-sdk2.26.0-ubuntu22.04But it should be:
0.10.2-neuronx-py310-sdk2.26.0-ubuntu22.04This pull-request also adds the
0.4.2version, that has a slightly different tag prefix to include explicitly the optimum neuron version.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.