fix(esplora): deduplicate missing txids in fetch_txs_with_outpoints#2104
Open
phrwlk wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix(esplora): deduplicate missing txids in fetch_txs_with_outpoints#2104phrwlk wants to merge 1 commit intobitcoindevkit:masterfrom
phrwlk wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
evanlinjin
requested changes
Jan 27, 2026
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
cACK
Looks good, thanks for fixing this.
Just a minor thing before merging - could you combine the two commits and include the scope?
I.e.
fix(esplora): deduplicate missing txids in fetch_txs_with_outpoints
phrwlk
force-pushed
the
fix/esplora-dedup-missing-txids-outpoints
branch
from
2c95146 to
0071ee6
Compare
phrwlk
changed the title
Author
Did it |
evanlinjin
force-pushed
the
fix/esplora-dedup-missing-txids-outpoints
branch
from
0071ee6 to
787e07c
Compare
Collaborator
|
Can you update the PR description to follow the template, and also add the changelog changes in it ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
fetch_txs_with_outpointscollected spend txids into a Vec, so the same txid could be pushed multiple times when one transaction spent several input outpoints. This caused redundantget_tx_infocalls to Esplora for the same transaction, wasting network and CPU without changing the resultingTxUpdate.Use
HashSet<Txid>formissing_txsin both async and blockingfetch_txs_with_outpoints,so each txid is only requested once while keeping the observable behaviour ofSyncResponse/TxUpdateunchanged.