This repository was archived by the owner on Nov 9, 2017. It is now read-only.
fix issue with Either deserialization with case classes#46
Open
nsanch wants to merge 1 commit intocodahale:developmentfrom
Open
fix issue with Either deserialization with case classes#46nsanch wants to merge 1 commit intocodahale:developmentfrom
nsanch wants to merge 1 commit intocodahale:developmentfrom
Conversation
EitherDeserializer was reusing a JsonParser first when it attempted to parse the Left, then if that failed and it tried to parse the Right. If the Left and Right sides look similar enough that the nextToken method was ever called on the parser, then the parsing of the Right could fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EitherDeserializer was reusing a JsonParser first when it attempted to
parse the Left, then if that failed and it tried to parse the Right. If
the Left and Right sides look similar enough that the nextToken method
was ever called on the parser, then the parsing of the Right could fail.