chore: fix PHPStan, Rector and tests#1310
Merged
michalsn merged 6 commits intocodeigniter4:developfrom Feb 7, 2026
Merged
Conversation
samsonasik
approved these changes
Feb 7, 2026
paulbalandan
approved these changes
Feb 7, 2026
Member
Author
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes PHPStan and Rector errors, resolves test-related issues with the
superglobalsservice, and adds PHP 8.5 to the test suite.PHPStan errors related to
withHeaders()are temporary, and will be fixed in the upstream, see: codeigniter4/CodeIgniter4#9932