Throw StackOverflowError from initMethodStack; add StackOverflowError class and native test#4461
Open
shai-almog wants to merge 25 commits intomasterfrom
Open
Throw StackOverflowError from initMethodStack; add StackOverflowError class and native test#4461shai-almog wants to merge 25 commits intomasterfrom
shai-almog wants to merge 25 commits intomasterfrom
Conversation
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
Compared 30 screenshots: 30 matched. Benchmark Results
Detailed Performance Metrics
|
e8df884 to
fb3ec1a
Compare
fb3ec1a to
56c72a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StackOverflowErrorso Java code can catch and recover.java.lang.StackOverflowErrorclass so the VM can instantiate and throw the error.Description
vm/JavaAPI/src/java/lang/StackOverflowError.javaimplementingjava.lang.VirtualMachineError.vm/ByteCodeTranslator/src/nativeMethods.mto include theStackOverflowErrorheader and changeinitMethodStackto checkcallStackOffsetand callthrowException(threadStateData, __NEW_INSTANCE_java_lang_StackOverflowError(threadStateData))and return instead of asserting.vm/tests/src/test/java/com/codename1/tools/translator/StackOverflowIntegrationTest.java, a native integration test that compiles a small app which triggers a stack overflow, verifies theStackOverflowErrorwas thrown/caught (STACK_OVERFLOW_OK) and that normal execution (a recursive sum) still works after recovery (RECOVERY_OK:7).Testing
StackOverflowIntegrationTestwas added undervm/testsand will run as part of the VM test suite when the test goals are invoked.Codex Task