feat: add extra headers support to responses endpoint #154
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawbana
approved these changes
Jan 28, 2026
dannykopping
approved these changes
Jan 28, 2026
| assert.Contains(t, err.Error(), "unmarshal responses request body") | ||
| }) | ||
|
|
||
| t.Run("Responses_ForwardsHeadersToUpstream", func(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Nit: since there's common behaviour I'd expect a common test.
This is fine for now but in general I'd like to support the same tests (using impl-specific fixtures) across both impls where it's simply input/output behaviour being tested.
Contributor
Author
There was a problem hiding this comment.
Yes, agree! Also thought about it, but wanted to keep the PR simple. I can address this in a follow-up PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for forwarding extra headers to the upstream provider when using OpenAI's
/responsesendpoint. This mirrors the existing functionality in the chat completions endpoint, ensuring Copilot-required headers (likeEditor-VersionandCopilot-Integration-Id) are properly forwarded.Changes
ExtraHeadersiteration inresponsesInterceptionBase.newResponsesService()to append configured headers to outgoing requestsResponses_ForwardsHeadersToUpstreamto verify Copilot headers are forwarded and non-Copilot headers are filteredFollow-up from: #137
Related to: coder/internal#1235