Skip to content

fix(catchers): validate beforeSend return value to avoid sending invalid payload #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dobrunia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(catchers): validate beforeSend return value to avoid sending invalid payload #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/javascript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hawk.so/javascript",
"version": "3.2.13",
"version": "3.2.14",
"description": "JavaScript errors tracking for Hawk.so",
"files": [
"dist"
Expand Down
4 changes: 3 additions & 1 deletion packages/javascript/src/catcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
EventContext,
JavaScriptAddons,
VueIntegrationAddons,
Json, EncodedIntegrationToken, DecodedIntegrationToken,

Check warning on line 13 in packages/javascript/src/catcher.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected trailing comma
} from '@hawk.so/types';
import type { JavaScriptCatcherIntegrations } from './types/integrations';
import { EventRejectedError } from './errors';
Expand Down Expand Up @@ -440,8 +440,10 @@

if (beforeSendResult === false) {
throw new EventRejectedError('Event rejected by beforeSend method.');
} else {
} else if (typeof beforeSendResult === 'object' && beforeSendResult !== null) {
payload = beforeSendResult;
} else if (beforeSendResult !== undefined) {
log('beforeSend must return event object or false. Received: ' + typeof beforeSendResult, 'warn');
}
}

Expand Down
Loading