feat: change addTool to multipart data by GeekaN2 · Pull Request #264 · codex-team/notes.api

GeekaN2 · 2024-07-02T21:56:17Z

slaveeks · 2024-07-03T22:01:45Z

src/domain/entities/file.ts

+ * Editor tool cover location
+ */
+export type EditorToolCoverFileLocation = {
+  isEditorToolCover: boolean;


maybe store toolId?

slaveeks · 2024-07-03T22:03:28Z

src/presentation/http/router/editorTools.ts

+      // body: {
+      //   $ref: 'AddEditorToolSchema',
+      // },


remove it, maybe add real validation?

slaveeks · 2024-07-03T22:04:10Z

src/presentation/http/router/editorTools.ts

+    if (editorTool.cover) {
+      const coverBuffer = await editorTool.cover.toBuffer();
+
+      coverKey = await fileUploaderService.uploadFile({
+        data: coverBuffer,
+        name: createFileId(),
+        mimetype: editorTool.cover.mimetype,
+      }, {
+        isEditorToolCover: true,
+      }, {
+        userId,
+      });
+    }


Lets move this logic into addTool()

slaveeks · 2024-07-03T22:05:07Z

src/repository/editorTools.repository.ts

+  /**
+   * Update tool cover
+   * @param editorToolId
+   * @param cover
+   */
+  public async updateToolCover(editorToolId: EditorTool['id'], cover: EditorTool['cover']): Promise<void> {


github-actions · 2024-07-04T16:28:37Z

Coverage Report

Status	Category	Percentage	Covered / Total
🟢	Lines	84.17% (🎯 80%) ⬇️ -1.31%	7874 / 9354
🟢	Statements	84.17% (🎯 80%) ⬇️ -1.31%	7874 / 9354
🔴	Functions	74.68% (🎯 80%) ⬇️ -3.13%	236 / 316
🟢	Branches	84.88% (🎯 80%) ⬇️ -0.45%	382 / 450

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/domain/entities/editorTools.ts	0%	0%	0%	0%	1-62
src/domain/entities/file.ts	100%	100%	100%	100%
src/domain/service/editorTools.ts	85.33%	100%	50%	85.33%	28-29, 51-52, 61-65, 73-74
src/domain/service/fileUploader.service.ts	47.08%	100%	20%	47.08%	60-100, 109-110, 118-145, 152-173, 180-189, 196-197, 204-205, 212-222
src/presentation/http/http-api.ts	96.05%	90.32%	93.75%	96.05%	101-109, 120-121, 323-324, 347-348
src/presentation/http/router/editorTools.ts	70.62%	100%	100%	70.62%	71-75, 113-154
src/presentation/http/router/oauth.ts	59.77%	100%	100%	59.77%	48-82
src/presentation/http/router/dto/AddEditorTool.dto.ts	0%	0%	0%	0%	1-46
src/presentation/http/schema/AddEditorTool.ts	100%	100%	100%	100%
src/presentation/http/schema/EditorTool.ts	100%	100%	100%	100%
src/repository/editorTools.repository.ts	82.6%	100%	50%	82.6%	22-25, 49-50, 56-59, 67-68
src/repository/storage/postgres/orm/sequelize/editorTools.ts	83.41%	100%	50%	83.41%	142-161, 189-194, 200-201, 209-216
src/tests/utils/database-helpers.ts	98.17%	95.23%	91.66%	98.17%	194-199

Generated in workflow #790

src/domain/service/editorTools.ts

src/domain/service/fileUploader.service.ts

src/presentation/http/router/dto/AddEditorTool.dto.ts

neSpecc · 2024-07-04T16:32:30Z

src/presentation/http/router/editorTools.ts

+      title: String(editorTool.title?.value),
+      name: String(editorTool.name?.value),


unsafe call

neSpecc · 2024-07-06T14:05:55Z

src/presentation/http/router/dto/AddEditorTool.dto.ts

+  cover?: MultipartFile;
+
+  /**
+   * The user ID associated with the editor tool.


is it the user who added a tool or who updated a tool last time?

neSpecc · 2024-07-06T14:07:04Z

src/presentation/http/router/editorTools.ts

+      title: editorTool.title?.value ?? '',
+      name: editorTool.name?.value ?? '',


you need to validate all required fields or add a schema

elizachi · 2024-07-07T23:32:01Z

src/domain/entities/file.ts

+  /**
+   * Tool cover
+   */
+  EditorToolCover = 2


What does the numbers mean? Add description please

elizachi · 2024-07-07T23:36:05Z

src/presentation/http/router/editorTools.test.ts

Remove all commented-out lines if it is not used

elizachi · 2024-07-07T23:41:20Z

src/presentation/http/router/editorTools.ts

-  const { editorToolsService } = opts;
+  const { editorToolsService, fileUploaderService } = opts;
+
+  await fastify.register(fastifyMultipart, {


I think the fastify.registed should be stored here
notes.api/src/presentation/http/http-api.ts

e11sy · 2024-07-08T08:13:29Z

src/domain/entities/file.ts

+  NoteAttachment = 1,
+
+  /**
+   * Tool cover
+   */
+  EditorToolCover = 2


lets store this as string enum for better readability

e11sy · 2024-07-08T08:36:24Z

src/presentation/http/router/editorTools.test.ts

+      // eslint-disable-next-line
+      const formData = new FormData();


spicify eslint rule that you are disabling

GeekaN2 force-pushed the feat/descriptions-and-covers branch from ece521b to 394023c Compare July 3, 2024 21:57

slaveeks reviewed Jul 3, 2024

View reviewed changes

GeekaN2 added 3 commits July 4, 2024 17:08

feat: change addTool to multipart data

6e5f088

fix: lint

7969916

fix: 1 test

60a0c18

GeekaN2 force-pushed the feat/descriptions-and-covers branch from a07998d to 60a0c18 Compare July 4, 2024 14:08

GeekaN2 added 2 commits July 4, 2024 19:25

tests: comment tests with multipart form data until fakeRequest update

694c216

fix: lint FormData

5cac917

neSpecc reviewed Jul 4, 2024

View reviewed changes

feat: add validation

93b4b62

neSpecc reviewed Jul 6, 2024

View reviewed changes

elizachi reviewed Jul 7, 2024

View reviewed changes

e11sy reviewed Jul 8, 2024

View reviewed changes

		title: String(editorTool.title?.value),
		name: String(editorTool.name?.value),

		title: editorTool.title?.value ?? '',
		name: editorTool.name?.value ?? '',

Conversation

GeekaN2 commented Jul 2, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Jul 4, 2024 •

edited

Loading