Open
Conversation
- More than two dices didn't work - L and H were inverted
Owner
|
Hey @luccasclezar, how are you doing? This package was based on an old version of JS' If you'd like to properly implement those notations (probably following the up-to-date version of that original package, I can review them and ship on a manjor version of this lib (given there is tests reflecting the new behavior). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this package is not maintained anymore, but I'm using it now so I thought to contribute by fixing these errors. 🙂
More than two dices didn't work when using -L or -H
Expressions like "10d10-L" summed some of the values instead of returning the lowest of all values.
L and H were inverted
When the results were [1, 2], -L returned 2 and -H returned 1.