test: remove temp variable and extract fixtures to shorten tests #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1809 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 60 60
Lines 2648 2648
=======================================
Hits 2594 2594
Misses 54 54 ☔ View full report in Codecov by Sentry. |
Lee-W
approved these changes
Jan 19, 2026
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
a few nits but mostly good. Thanks!
bearomorphism
force-pushed
the
test-bump-shorten
branch
3 times, most recently
from
1dd15fe to
18a17bd
Compare
bearomorphism
force-pushed
the
test-bump-shorten
branch
from
18a17bd to
cfe0b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Parameterized some tests, and extracted some duplicated patterns to fixtures.