dcache cli: fix issue with printing pool size when max diskspace is s… #8017
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et in percentage Motivation: ----------- patch 8c71927 introduced ability to specify max disk space in percentage of partition space like so: set max diskspace 98% unfortunately it breaks dcache pool ls command like so: 98% is not an integer. Modification: ------------ Calculate pool size based on partition size and percentage Result: ------ No error when running "dcache pool ls" and pool size properly reported Ticket: #8014 Patch: https://rb.dcache.org/r/14618/ Acked-by: Marina Request: trunk Target: 11.x Require-book: no Require-notes: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…et in percentage
Motivation:
patch 8c71927 introduced ability to specify max disk space in percentage of partition space like so:
set max diskspace 98%
unfortunately it breaks dcache pool ls command like so:
98% is not an integer.
Modification:
Calculate pool size based on partition size and percentage
Result:
No error when running "dcache pool ls" and pool size properly reported
Ticket: #8014
Patch: https://rb.dcache.org/r/14618/
Acked-by: Marina
Request: trunk
Target: 11.x
Require-book: no
Require-notes: yes