Replace old log based waits with DaprWait strategy. #1635
Merged
+10
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Ciocanu <[email protected]>
Contributor
Author
|
@dapr/maintainers-java-sdk and @dapr/approvers-java-sdk could you please take a look. This is a simple PR trying to use the newly added DaprWait strategy so we have more control around when a test is ready to be executed, instead of relying on log messages which can change and are unreliable. |
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
salaboy
requested changes
Feb 1, 2026
Collaborator
salaboy
left a comment
salaboy
left a comment
There was a problem hiding this comment.
LGTM .. this is a great improvement @artur-ciocanu , we just need to get the codecov up.
Signed-off-by: Artur Ciocanu <[email protected]>
Contributor
Author
|
@salaboy thanks for looking into this, everything is 🟢 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1635 +/- ##
=========================================
Coverage 78.99% 78.99%
Complexity 2096 2096
=========================================
Files 228 228
Lines 6321 6321
Branches 693 693
=========================================
Hits 4993 4993
Misses 976 976
Partials 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace old log based Testcontainer waits with DaprWait strategy.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: