Fix Logitech G25 Sequential Shifting Direction#23
Merged
Conversation
Per comments in #21, this fixes the Logitech G25 shifter's sequential shifting so that upshifting is towards the user and downshifting is away from the user, matching the markings on the shifter itself. This changes the expected behavior of the up / down shift functions, but should maintain compatibility with existing user calibrations.
User feedback, matching the H-pattern calibration
Same behavior, less wordy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per comments in #21, the Logitech G25 shifter's sequential shifting mode was incorrectly set up so that pushing the shifter away shifted up, and pulling the shifter shifted down. This fixes the implementation so that pulling the shifter shifts up, and pushing the shifter shifts down. This matches the printed marking on my own shifter, as well as real-world sequential lever shifters in rally cars.
I've also added clarifying comments in the
LogitechShifterG25class to that effect, and improved the wording for the sequential shifting interactive calibration.