Use native PHP Exception Code to transmit HTTP response code#54
Open
romaninsh wants to merge 2 commits intoeducoder:masterfrom
Open
Use native PHP Exception Code to transmit HTTP response code#54romaninsh wants to merge 2 commits intoeducoder:masterfrom
romaninsh wants to merge 2 commits intoeducoder:masterfrom
Conversation
As per PHP manual, Exceptions supports specifying error codes through 2nd argument of constructor: http://www.php.net/manual/en/exception.getcode.php This patch makes use of standard PHP functionality to transmit error codes. This adds support for un-handled response types such as 402, 420 and others.
Member
|
Can anyone think of a reason why this shouldn't be merged? I haven't written a line of PHP in about two years so not the best person to make the call on this, but I can imagine it being useful. |
|
Seems pretty straightforward to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per PHP manual, Exceptions supports specifying error codes through
2nd argument of constructor:
http://www.php.net/manual/en/exception.getcode.php
This patch makes use of standard PHP functionality to transmit error
codes. This adds support for un-handled response types such as 402, 420
and others.