dynamic_modules: add stats access APIs to Bootstrap Extension #43029
+796
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawroh
force-pushed
the
feat-dm-bts-1
branch
4 times, most recently
from
fba9c61 to
1c63ab4
Compare
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
mathetake
reviewed
Jan 16, 2026
| * @param iterator_fn is the callback function to call for each gauge. | ||
| * @param user_data is the user data to pass to the callback function. | ||
| */ | ||
| void envoy_dynamic_module_callback_bootstrap_extension_iterate_gauges( |
mathetake
previously approved these changes
Jan 16, 2026
mathetake
reviewed
Jan 16, 2026
|
|
||
| // Iterate over all counters to find the one with matching name. | ||
| bool found = false; | ||
| stats_store.forEachCounter([](size_t) {}, |
Member
There was a problem hiding this comment.
oh wait is there no way to lookup faster than O(n)?
Member
Author
There was a problem hiding this comment.
Looks like there isn't :(
Member
Author
There was a problem hiding this comment.
Actually, I think I can use iterate() instead and exit early. Let me switch to that. That will let us do it in O(k) instead of a full scan.
Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
feat-dm-bts-1
branch
from
1c63ab4 to
94bc7e7
Compare
mathetake
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds stats access APIs to the Bootstrap Extension.
Commit Message: dynamic_modules: add stats access APIs to Bootstrap Extension
Additional Description: Added stats access APIs to the Bootstrap Extension.
Risk Level: Low
Testing: Added Tests
Docs Changes: N/A
Release Notes: N/A